Opened 6 years ago

Closed 6 years ago

#10924 closed enhancement (implemented)

Include instructions on generating geoip and geoip6 files

Reported by: karsten Owned by:
Priority: Medium Milestone: Tor: 0.2.5.x-final
Component: Core Tor/Tor Version:
Severity: Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

nickm said on #10910:

Also, I would like an improved README.geoip if possible, to explain how the geoip files are generated now. Should I open a new ticket for that?

If we just want to note the commands necessary to generate the files, how about we write them to the header of geoip and geoip6 files, which is what we did before the A1 madness started. For example, here's how the first lines of geoip could look like:

# Last updated based on February 7 2014 Maxmind GeoLite2 Country
# wget http://geolite.maxmind.com/download/geoip/database/GeoLite2-Country.mmdb.gz
# gunzip GeoLite2-Country.mmdb.gz
# python mmdb-convert.py GeoLite2-Country.mmdb
16777216,16777471,AU

Or we could write these commands to a small README.geoip. In this case, is there anything else we'd want to include in this file? The downside, however, would be that README.geoip would only go into master and not into maint-0.2.3 or maint-0.2.4.

Let me know what you prefer, and I'll write a patch.

Child Tickets

Change History (3)

comment:1 Changed 6 years ago by nickm

The short-comment version is fine with me.

comment:2 Changed 6 years ago by karsten

Status: newneeds_review

Please find my branch bug10924 with a patch to mmdb-convert.py. And please let me know if you want updates to the current geoip files. If not, I'd include the new header in the next database update.

comment:3 Changed 6 years ago by nickm

Resolution: implemented
Status: needs_reviewclosed

Merged; thanks! No need to regenerate existing geoip files IMO.

Note: See TracTickets for help on using tickets.