Opened 6 years ago

Closed 6 years ago

#10926 closed defect (fixed)

Fix a linker error in csiphash.c on OpenBSD

Reported by: _x3j11 Owned by:
Priority: Medium Milestone: Tor: 0.2.5.x-final
Component: Core Tor/Tor Version:
Severity: Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

src/ext/csiphash.c was recently imported. It however has a small defect which means that building on OpenBSD has broken with a linker error for le64toh (see the CONFORMING TO section of endian(3) on Linux). The attached patch corrects this.

Child Tickets

Attachments (1)

0001-Appropriately-condition-the-_le64toh-macro-definitio.patch (914 bytes) - added by _x3j11 6 years ago.

Download all attachments as: .zip

Change History (3)

comment:1 Changed 6 years ago by _x3j11

Status: newneeds_review

comment:2 Changed 6 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

Seems plausible; merging. (Thanks!) Maybe also submit this fix upstream to https://github.com/majek/csiphash/ ?

Note: See TracTickets for help on using tickets.