Tor Browser leaves developer windows open after New Identity

When you open menu entry "View Page Source" from a web page, a new window will open showing the source code. Then, when you select new identity from the onion menu, all tabs are cleared BUT that page/window with source code will stay there, it's not closed.

Tor Browser 3.5.2

Trac:
Username: anon

added component::applications/tor browser gitlab-tb-torbutton owner::tbb-team priority::medium reporter::anon severity::normal status::new tbb-newnym tbb-torbutton type::defect labels

Note: that happens for an open browser/error console as well.

Trac:
Cc: N/A to gk
Component: - Select a component to TorBrowserButton
Owner: N/A to mikeperry
Keywords: N/A deleted, tbb-usability, tbb-newnym added

Trac:
Component: TorBrowserButton to Tor Browser
Keywords: N/A deleted, tbb-torbutton added
Owner: mikeperry to tbb-team

Trac:
Keywords: tbb-usability deleted, N/A added
Summary: View Page Source Tor Browser 3.5.2 to Tor Browser leaves developer windows open after New Identity

#18033 (moved) is a duplicate, see #5309 (moved) as well.

Trac:
Severity: N/A to Normal
Sponsor: N/A to N/A

Trac:
Cc: gk to gk, brade, mcs

Using Tor Browser 6.5, I cannot reproduce this problem for "View Page Source" windows. I think it is okay to leave the Browser Console and other non-content windows open across the New Identity transition, but if anyone disagrees please reopen this ticket.

Trac:
Reviewer: N/A to N/A
Status: new to closed
Resolution: N/A to worksforme

We are already closing the current window for added safety and I think we should do this for any other window as well. It leaves out whole classes of corner cases nobody else but us would be caring about by providing always a clean slate.

And, given the bunch of duplicates over time it seems confusing to users that windows stay open between sessions while the main window is going away.

Trac:
Status: closed to reopened
Resolution: worksforme to N/A

FWIW: This happens for the about window as well: https://blog.torproject.org/blog/tor-browser-70a2-released#comment-241674.

And the bookmark toolbar, too: https://blog.torproject.org/comment/280245#comment-280245.

Trac:
Status: reopened to new

and view page info - see #32987 (moved) (which I closed as a dupe of this)

also see https://trac.torproject.org/projects/tor/ticket/13854#comment:3 for why view page-source is no longer an issue

Add magic gitlab keyword.

Trac:
Keywords: N/A deleted, gitlab-tb-torbutton added

mentioned in issue #13854 (moved)

mentioned in issue #18033 (moved)

mentioned in issue #32987 (moved)

moved to tpo/applications/torbutton#10952 (closed)