Opened 6 years ago

Closed 6 years ago

#10987 closed defect (fixed)

IPv6 is not working when using SocksPort

Reported by: dgoulet Owned by:
Priority: Medium Milestone: Tor: 0.2.5.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: tor-client ipv6 024-backport
Cc: nickm, athena, ln5 Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Tor daemon replies to a SOCKS5 connect command with an IPv4 payload when using IPv6 thus making the client trying to receive too much bytes and failing to use IPv6 with a SOCKS5 connection.

I'll be submitting a patch for this soon. Just need to get this bug number and make the changes file.

Child Tickets

Change History (6)

comment:1 Changed 6 years ago by dgoulet

Status: newneeds_review

Here is the pull request:

https://github.com/dgoulet/tor.git (branch: bug10987)

Commit: 63ad688e6b4edefc554d96511b363b9179b5023f

Last edited 6 years ago by dgoulet (previous) (diff)

comment:2 Changed 6 years ago by nickm

Keywords: tor-client ipv6 024-backport added
Milestone: Tor: 0.2.4.x-final

This looks right. I've tweaked the whitespace a little and made a "bug10987_024" branch in case we want to backport. I've merged to 0.2.5, and I'm marking this one for possible 0.2.4 backport.

comment:3 Changed 6 years ago by nickm

Recommendation: unsure. Simple fix for a bug that kept ipv6 from working. OTOH, not a regression.

comment:4 Changed 6 years ago by arma

How much does ipv6 work in 0.2.4 otherwise? If there are other fixes in 0.2.5 that will make you want to use that one instead, then no backport. If this really is the only thing standing between you and happy ipv6 usage, I could maybe be talked into it? That said, 0.2.5 will be out real soon, and sooner if we don't muck with 0.2.4.

comment:5 Changed 6 years ago by nickm

I think that IPv6 sorta works in 0.2.4, and this fixes the case where you want to specify an IPv6 address via SOCKS. OTOH, the best reason to do that is AutomapHostsOnResolve, and see also #10468.

comment:6 Changed 6 years ago by nickm

Milestone: Tor: 0.2.4.x-finalTor: 0.2.5.x-final
Resolution: fixed
Status: needs_reviewclosed

Aaaand without #10468 , this isn't so useful. Oh look, something finally starts working in 0.2.5.

Note: See TracTickets for help on using tickets.