Opened 6 years ago

Last modified 13 months ago

#11013 new defect

Windows installer's language should default to the bundle's language

Reported by: dcf Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: l10n
Cc: arthuredelstein, emmapeel, StrangeCharm Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

When you open a localized torbrowser-installer exe bundle, the installer's language combobox defaults to English, whatever the localization.

Child Tickets

Change History (9)

comment:1 Changed 5 years ago by erinn

Keywords: needs-triage added

comment:2 Changed 4 years ago by cypherpunks

To change defaults you need to change NSIS script during browser building instead of using statically fetched:
https://github.com/moba/tbb-windows-installer/blob/master/torbrowser.nsi#L54

!insertmacro MUI_LANGUAGE "English" ;first language is the default language

comment:3 Changed 4 years ago by cypherpunks

Just tested vanilla Firefox ESR installers. They doesn't allows to choose language, no any combobox, but installs using localization of bundle.

comment:4 Changed 23 months ago by teor

Severity: Normal

Set all open tickets without a severity to "Normal"

comment:5 Changed 14 months ago by gk

Cc: arthurdelstein emmapeel StrangeCharm added
Component: Applications/Tor bundles/installationApplications/Tor Browser
Keywords: l10n added; needs-triage removed
Owner: changed from erinn to tbb-team

#17514 is a duplicate.

comment:6 Changed 14 months ago by dcf

See also #13469—some of Tor Browser's supported localizations (e.g. Chinese, Farsi) are not even present in the installer combobox, apparently due to a font encoding issue. A few years ago when I was looking into it, I found that a newer version of NSIS (v3.0+) would be needed for Unicode support.

comment:7 in reply to:  6 Changed 14 months ago by gk

Replying to dcf:

See also #13469—some of Tor Browser's supported localizations (e.g. Chinese, Farsi) are not even present in the installer combobox, apparently due to a font encoding issue. A few years ago when I was looking into it, I found that a newer version of NSIS (v3.0+) would be needed for Unicode support.

That's actually fixed in 8.0a9 which is using NSIS 3.

comment:8 in reply to:  description Changed 14 months ago by fixtbb

Replying to dcf:

When you open a localized torbrowser-installer exe bundle, the installer's language combobox defaults to English, whatever the localization.

But en_US installer's combobox defaults to System (Current user's language in OS).

comment:9 Changed 13 months ago by boklm

Cc: arthuredelstein added; arthurdelstein removed
Note: See TracTickets for help on using tickets.