Opened 4 years ago

Closed 3 years ago

#11014 closed defect (fixed)

"Start Tor Browser.exe" from another directory fails to start Tor Launcher, gives Mozilla branding

Reported by: dcf Owned by: erinn
Priority: Low Milestone:
Component: Applications/Tor Browser Version:
Severity: Keywords: needs-triage
Cc: gk Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

If you run Start Tor Browser.exe from the command line from other than the directory it's in, Tor Launcher doesn't run and you get the normal Firefox branding. If you try to browse anywhere, you get "The proxy server is refusing connections".

Child Tickets

Attachments (2)

wrongdir.png (131.8 KB) - added by dcf 4 years ago.
How it looks when you run from a different directory.
rightdir.png (46.6 KB) - added by dcf 4 years ago.
How it looks when you run from the same directory.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 4 years ago by dcf

Here's what it looks like when you run from the parent directory. The other side effect is that new file hierarchy is created in Data\Browser\profile.default relative to the directory you're running in. What's going wrong is that RelativeLink.c tries to start with a profile in that directory, it doesn't exist, so Firefox creates it.

How it looks when you run from a different directory.

It works when you run from the same directory.

How it looks when you run from the same directory.

#9563 was a conceptually similar problem on another platform.

I found this bug while testing attachment:0001-Put-the-Tor-subdirectory-at-the-head-of-PATH-for-DLL.patch:ticket:10845, which will probably need to be fixed along with this ticket because it uses GetCurrentDirectory.

Last edited 4 years ago by dcf (previous) (diff)

Changed 4 years ago by dcf

Attachment: wrongdir.png added

How it looks when you run from a different directory.

Changed 4 years ago by dcf

Attachment: rightdir.png added

How it looks when you run from the same directory.

comment:2 Changed 4 years ago by cypherpunks

What if to change current directory to directory of RelativeLink.c executable.
With series of functions like:
GetModuleHandle, GetModuleFileName, PathCchRemoveFileSpec (PathRemoveFileSpec), SetCurrentDirectory.

Last edited 4 years ago by cypherpunks (previous) (diff)

comment:3 Changed 4 years ago by gk

Cc: gk added

comment:4 Changed 4 years ago by erinn

Keywords: needs-triage added

comment:5 Changed 3 years ago by cypherpunks

Component: Tor bundles/installationTor Browser
Status: newneeds_information

Is this still an issue since 4.0 release?

comment:6 Changed 3 years ago by cypherpunks

Resolution: fixed
Status: needs_informationclosed

Tested 4.x

Tried first:

C:\Users\user\Desktop\Tor Browser>"Start Tor Browser.lnk"

Then:

C:\Users\user>"Desktop\Tor Browser\Start Tor Browser.lnk"

And directly:

C:\Users\user>"Desktop\Tor Browser\Browser\firefox.exe"

Everything works just fine with the same result for every case.
Closing this ticket as auto-magically fixed. Please reopen if disagree.

Note: See TracTickets for help on using tickets.