Opened 10 years ago

Last modified 3 months ago

#1102 needs_information defect (None)

Queuing v3 signature for next consensus, an hour later?

Reported by: arma Owned by:
Priority: Low Milestone: Tor: unspecified
Component: Core Tor/Tor Version: 0.2.1.19
Severity: Normal Keywords: tor-dirauth
Cc: arma, karsten, nickm, Sebastian Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description (last modified by nickm)

On moria1, which I started at
Sep 21 01:51:04.434 (after some parts of the consensus generation were
supposed to start)

Sep 21 01:51:47.809 [notice] Uploaded a vote to dirserver 128.31.0.34:9031
Sep 21 01:51:47.832 [notice] Uploaded a vote to dirserver 216.224.124.114:9030
Sep 21 01:51:47.833 [notice] Uploaded a vote to dirserver 208.83.223.34:443
Sep 21 01:51:48.045 [notice] Uploaded a vote to dirserver 86.59.21.38:80
Sep 21 01:51:48.311 [notice] Uploaded a vote to dirserver 194.109.206.212:80
Sep 21 01:51:49.618 [notice] Uploaded a vote to dirserver 213.73.91.31:80
Sep 21 01:51:49.662 [notice] Uploaded a vote to dirserver 80.190.246.100:80
...
Sep 21 01:52:31.466 [notice] Time to fetch any votes that we're missing.
Sep 21 01:52:31.466 [notice] We're missing votes from 6 authorities. Asking every other authority for a copy.
...
Sep 21 01:55:01.379 [notice] Time to compute a consensus.
Sep 21 01:55:01.586 [notice] Consensus computed; uploading signature(s)
Sep 21 01:55:01.587 [notice] Signature(s) posted.
Sep 21 01:55:01.611 [notice] Got a signature from 128.31.0.34. Adding it to the pending consensus.
Sep 21 01:55:01.612 [notice] Uploaded signature(s) to dirserver 128.31.0.34:9031
Sep 21 01:55:01.763 [notice] Uploaded signature(s) to dirserver 216.224.124.114:9030
Sep 21 01:55:01.770 [notice] Uploaded signature(s) to dirserver 208.83.223.34:443
Sep 21 01:55:01.846 [notice] Uploaded signature(s) to dirserver 86.59.21.38:80
Sep 21 01:55:01.854 [notice] Got a signature from 86.59.21.38. Adding it to the pending consensus.
Sep 21 01:55:01.930 [notice] Uploaded signature(s) to dirserver 194.109.206.212:80
Sep 21 01:55:01.934 [notice] Got a signature from 194.109.206.212. Adding it to the pending consensus.
Sep 21 01:55:02.827 [notice] Got a signature from 208.83.223.34. Adding it to the pending consensus.
Sep 21 01:55:02.869 [notice] Got a signature from 216.224.124.114. Adding it to the pending consensus.
Sep 21 01:55:05.121 [notice] Got a signature from 213.73.91.31. Adding it to the pending consensus.
Sep 21 01:55:05.675 [notice] Uploaded signature(s) to dirserver 213.73.91.31:80
Sep 21 01:55:08.879 [notice] Got a signature from 80.190.246.100. Adding it to the pending consensus.
Sep 21 01:55:09.307 [notice] Uploaded signature(s) to dirserver 80.190.246.100:80
Sep 21 01:57:31.840 [notice] Time to fetch any signatures that we're missing.
Sep 21 02:00:01.204 [notice] Time to publish the consensus and discard old votes
Sep 21 02:00:01.231 [notice] Choosing expected valid-after time as 2009-09-21 07:00:00: consensus_set=1, interval=3600
Sep 21 02:00:01.300 [notice] Consensus published.
Sep 21 02:00:01.301 [notice] Choosing expected valid-after time as 2009-09-21 07:00:00: consensus_set=1, interval=3600
Sep 21 02:00:09.474 [notice] Got a signature from 38.229.70.2. Queuing it for the next consensus.

It's that last line that concerns me. Queuing for the next consensus that's 59 minutes
and 50 seconds from now? Shouldn't we either be adding it to the current consensus even
though it's late, or discarding it because it's late?

(Note that this isn't from an authority that moria1 recognizes)

[Automatically added by flyspray2trac: Operating System: All]

Child Tickets

Change History (14)

comment:1 Changed 9 years ago by nickm

Milestone: Tor: 0.2.2.x-final
Owner: set to nickm
Status: newassigned

I am *pretty* sure that we'll wind up discarding it when we start the next round of voting. But really, we should at least check harder to make sure it goes on the right consensus, or gets thrown out right away. I'll investigate here.

comment:2 Changed 9 years ago by nickm

Description: modified (diff)

On the bright side: This will not hurt anything major. We can only get this message if we have no pending consensus, meaning that either we have nothing to add it to yet, or if we have made a complete consensus, which is only possible if we got enough signatures from others.

On the un-bright side: we will indeed hang on to this detached signature document till the next round of voting, at which point we will try to add it to the consensus, then drop it because it doesn't apply. Really, we should try adding it to our existing consensus. Sadly, I don't think there's a function for that. Refactoring may be needed.

I am not sure this is critical for 0.2.2.x.

comment:3 Changed 9 years ago by arma

Triage: no need for this to hold up 0.2.2.x. It should get fixed or resolved or something someday, but that can be done on the authority side, so no need to get the fix out for 0.2.2.x

comment:4 Changed 9 years ago by nickm

Milestone: Tor: 0.2.2.x-final

Removing from the 0.2.2.x milestone.

comment:5 Changed 9 years ago by nickm

Milestone: Tor: 0.2.3.x-final

comment:6 Changed 9 years ago by arma

Component: Tor RelayTor Directory Authority

comment:7 Changed 7 years ago by nickm

Milestone: Tor: 0.2.3.x-finalTor: unspecified

Kicking this back to "unspecified", since it is tricky and harmless.

comment:8 Changed 7 years ago by nickm

Keywords: tor-auth added

comment:9 Changed 7 years ago by nickm

Component: Tor Directory AuthorityTor

comment:10 Changed 2 years ago by dgoulet

Cc: arma,karsten,nickm,Sebastianarma, karsten, nickm, Sebastian
Keywords: tor-dirauth added; tor-auth removed

Turns out that tor-auth is for directory authority so make it clearer with tor-dirauth

comment:11 Changed 2 years ago by nickm

Severity: Normal
Status: assignedneeds_information

Um, 7 years have passed. Is this still happening? :)

comment:12 Changed 2 years ago by arma

Yes, it is still happening. It happens when a dir auth is slightly wrong about time, or when the dir auth is heavily loaded so it is slow in sending its things.

It can happen not just for signatures, but for votes too.

comment:13 Changed 3 months ago by nickm

Owner: nickm deleted
Status: needs_informationassigned

I'm listed as the owner of these needs_information tickets, but I'm not currently doing anything with them. Reassigning to nobody, then putting back in needs_information.

comment:14 Changed 3 months ago by nickm

Status: assignedneeds_information
Note: See TracTickets for help on using tickets.