Opened 6 years ago

Closed 6 years ago

#11054 closed defect (fixed)

Fall back to registered country if necessary

Reported by: karsten Owned by:
Priority: Medium Milestone:
Component: Core Tor/Tor Version:
Severity: Keywords: tor-client tor-relay
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

When extracting geoip and geoip6 files from MaxMind's GeoLite2 Country database, we only look at country->iso_code which is the two-character ISO 3166-1 country code of the country where MaxMind believes the end user is located.

But if MaxMind thinks a range belongs to anonymous proxies, they don't put anything there. Hence, we omit those ranges and resolve them all to '??'. That's not what we want.

What we should do is first try country->iso_code, and if there's no such key, try registered_country->iso_code which is the country in which the ISP has registered the IP address.

In short: let's fill all A1 entries with what ARIN et. al think.

Found while updating Onionoo to use GeoLite2 instead of GeoLite. Sorry for not spotting this earlier.

Child Tickets

Change History (2)

comment:1 Changed 6 years ago by karsten

Status: newneeds_review

Please find my branches geoip2regcountry for an updated mmdb-convert.py and geoip-feb2014-regcountry for the updated geoip file. The geoip6 file is not affected, so I didn't create a new branch to update it.

comment:2 Changed 6 years ago by karsten

Resolution: fixed
Status: needs_reviewclosed

Looks like both branches are merged. Thanks! Closing. (Please reopen if this was premature.)

Note: See TracTickets for help on using tickets.