Opened 6 years ago

Closed 6 years ago

#11060 closed defect (fixed)

socks-extensions.txt says username/password are ignored

Reported by: arma Owned by:
Priority: Medium Milestone: Tor: 0.2.5.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: tor-spec doc easy
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:


In torspec's socks-extensions.txt, we say

    and as of Tor, the "USERNAME/PASSWORD" (SOCKS5)
    authentication method [02] is supported too. Any credentials passed to
    the latter are ignored.

But don't we use them for stream isolation now?

Also (hit-and-run two-bugs-in-one-ticket faux pas, sorry), the Tor man page says:

               Don’t share circuits with streams for which different SOCKS
               authentication was provided. (On by default; you can disable it
               with NoIsolateSOCKSAuth.)

which makes it sound like we look at SOCKS4 username too -- maybe we should change SOCKS to SOCKS5 in this man page stanza?

Child Tickets

Change History (1)

comment:1 Changed 6 years ago by nickm

Keywords: doc easy added
Resolution: fixed
Status: newclosed

Agreed; Fixed in 5b875a19f2de7da4a7c7cf66a810a4f33b81f57a.

Note: See TracTickets for help on using tickets.