Opened 10 years ago

Closed 9 years ago

Last modified 7 years ago

#1107 closed defect (fixed)

PublishServerDescriptor allows options 0 and 1 simultaneously

Reported by: Sebastian Owned by:
Priority: Low Milestone: Tor: 0.2.2.x-final
Component: Core Tor/Tor Version: 0.2.1.19
Severity: Keywords: easy
Cc: Sebastian, nickm Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description (last modified by Sebastian)

That doesn't make sense, and I think we should reject a config like that.

[Automatically added by flyspray2trac: Operating System: All]

Child Tickets

Attachments (2)

Change History (10)

comment:1 Changed 10 years ago by nickm

Hm. My inclination would be to warn if 0 or 1 is given in a list that is not a one-element list. It is not
reasonable for either one to appear except on its own.

Then we can change the warning to a "reject the configuration" in 0.2.3.x.

comment:2 Changed 9 years ago by nickm

Keywords: easy added
Milestone: Tor: 0.2.2.x-final

comment:3 Changed 9 years ago by cjb

Attached a tested patch. Please review carefully, since I'm still new to the codebase; thanks.

comment:4 Changed 9 years ago by cjb

Attached v2 of the patch. Changes:

  • Fix a check-spaces warning due to 80-char line
  • Explain when the bug was introduced in the changes file.

comment:5 Changed 9 years ago by Sebastian

Description: modified (diff)

Looks good to me now; thanks!

comment:6 Changed 9 years ago by nickm

Status: newneeds_review

comment:7 Changed 9 years ago by nickm

Resolution: Nonefixed
Status: needs_reviewclosed

Looks fine; merging. [You could also have used smartlist_string_isin().]

comment:8 Changed 7 years ago by nickm

Component: Tor ClientTor
Note: See TracTickets for help on using tickets.