Opened 10 years ago

Closed 9 years ago

#1110 closed enhancement (fixed)

Popup box asking about language preference

Reported by: arma Owned by: mikeperry
Priority: Very High Milestone:
Component: Applications/Torbutton Version: 1.2.2
Severity: Keywords:
Cc: arma Actual Points: 2
Parent ID: Points: 2
Reviewer: Sponsor:

Description (last modified by mikeperry)

Some Torbutton users complain that Tor is "english only", because it forces
you to ask for en pages. There's a checkbox to disable it, sure, but it's
hard to find and hard to know about.

How about Torbutton checks on its first start if your language prefs are
non-English, and pops up a dialog box:
"You have set your language preference to %s. Should I keep you safe
by making you blend together with all the other Torbutton users, or should I let
you use your own language?"

[Automatically added by flyspray2trac: Operating System: All]

Child Tickets

Attachments (2)

language_prompt.patch (2.4 KB) - added by chrisdoble 9 years ago.
language_prompt.2.patch (2.7 KB) - added by chrisdoble 9 years ago.

Download all attachments as: .zip

Change History (17)

comment:1 Changed 9 years ago by mikeperry

Description: modified (diff)
Priority: minormajor
Type: defectenhancement

comment:2 Changed 9 years ago by arma

Priority: majorcritical

Mike suggested I mark this 'critical' if I want to see it get done sometime. I think this is one of the (several) reasons why people in China ignore Torbutton.

Changed 9 years ago by chrisdoble

Attachment: language_prompt.patch added

comment:3 Changed 9 years ago by chrisdoble

I've attached a patch that implements this functionality.

The prompt is displayed if it hasn't been displayed before, rather than only on a fresh install. That way, if a user who previously uninstalled the extension reinstalls it, it will be displayed. The only problem is that it will be shown to users who upgrade to the latest version. What would be the best solution to this?

comment:4 Changed 9 years ago by Sebastian

IMO displaying the the dialog for users that had torbutton installed previously is fine. Maybe suppress the display if the torbutton pref to force en is set?

comment:5 Changed 9 years ago by chrisdoble

I updated the code to suppress the prompt if the user has modified the preference (meaning they know about it).

Changed 9 years ago by chrisdoble

Attachment: language_prompt.2.patch added

comment:6 Changed 9 years ago by mikeperry

Owner: set to koryk
Status: newassigned

comment:7 Changed 9 years ago by mikeperry

Points: 1

Review+merge patch: 1

comment:8 Changed 9 years ago by mikeperry

Status: assignedneeds_review

comment:9 Changed 9 years ago by mikeperry

I think arma wants to make users aware of the option in either case. We should ask users who don't have the pref set if they want to spoof english so that they are safer, and we should ask users who do have the pref set if they might like to view websites in their native language.

For this reason, I think I'm going to go with the first patch, though I'm going to edit the message and add it to our i18n strings.

comment:10 Changed 9 years ago by mikeperry

Points: 12

Reivew: 1
Adding i18n support: 1

comment:11 Changed 9 years ago by mikeperry

Ok, this is fixed in origin/master. It's going to need the transifex magic spells to pull in the .properties strings to build an .xpi that works with it though..

comment:12 Changed 9 years ago by arma

s/who's popup/whose popup/

s/webppages/webpages/ (one could also argue it should be 'web pages')

comment:13 Changed 9 years ago by mikeperry

Owner: changed from koryk to mikeperry
Status: needs_reviewassigned

comment:14 Changed 9 years ago by mikeperry

Actual Points: 2
actualpointsdone: 2
pointsdone: 2

comment:15 Changed 9 years ago by mikeperry

Resolution: Nonefixed
Status: assignedclosed

FYI: Fixed those typos in origin/master.

Note: See TracTickets for help on using tickets.