Popup box asking about language preference

Some Torbutton users complain that Tor is "english only", because it forces you to ask for en pages. There's a checkbox to disable it, sure, but it's hard to find and hard to know about.

How about Torbutton checks on its first start if your language prefs are non-English, and pops up a dialog box: "You have set your language preference to %s. Should I keep you safe by making you blend together with all the other Torbutton users, or should I let you use your own language?"

[Automatically added by flyspray2trac: Operating System: All]

added actualpoints::2 component::applications/torbutton owner::mikeperry points::2 priority::very high resolution::fixed status::closed type::enhancement version::1.2.2 labels

Trac:
Type: defect to enhancement
Description: Some Torbutton users complain that Tor is "english only", because it forces you to ask for en pages. There's a checkbox to disable it, sure, but it's hard to find and hard to know about.

How about Torbutton checks on its first start if your language prefs are non-English, and pops up a dialog box: "You have set your language preference to %s. Should I keep you safe by making you blend together with all the other Torbutton users, or should I let you use your own language?"

[Automatically added by flyspray2trac: Operating System: All]

to

Some Torbutton users complain that Tor is "english only", because it forces you to ask for en pages. There's a checkbox to disable it, sure, but it's hard to find and hard to know about.

How about Torbutton checks on its first start if your language prefs are non-English, and pops up a dialog box: "You have set your language preference to %s. Should I keep you safe by making you blend together with all the other Torbutton users, or should I let you use your own language?"

[Automatically added by flyspray2trac: Operating System: All]
Keywords: N/A deleted, N/A added
Milestone: N/A to N/A
Priority: minor to major

Mike suggested I mark this 'critical' if I want to see it get done sometime. I think this is one of the (several) reasons why people in China ignore Torbutton.

Trac:
Parent: N/A to N/A
Priority: major to critical

Trac:
Username: chrisdoble

language_prompt.patch

Trac:
Username: chrisdoble

I've attached a patch that implements this functionality.

The prompt is displayed if it hasn't been displayed before, rather than only on a fresh install. That way, if a user who previously uninstalled the extension reinstalls it, it will be displayed. The only problem is that it will be shown to users who upgrade to the latest version. What would be the best solution to this?

Trac:
Username: chrisdoble

IMO displaying the the dialog for users that had torbutton installed previously is fine. Maybe suppress the display if the torbutton pref to force en is set?

I updated the code to suppress the prompt if the user has modified the preference (meaning they know about it).

Trac:
Username: chrisdoble

Trac:
Username: chrisdoble

language_prompt.2.patch

Trac:
Username: chrisdoble

Trac:
Status: new to assigned
Owner: N/A to koryk

Review+merge patch: 1

Trac:
Points: N/A to 1

Trac:
Status: assigned to needs_review

I think arma wants to make users aware of the option in either case. We should ask users who don't have the pref set if they want to spoof english so that they are safer, and we should ask users who do have the pref set if they might like to view websites in their native language.

For this reason, I think I'm going to go with the first patch, though I'm going to edit the message and add it to our i18n strings.

Reivew: 1 Adding i18n support: 1

Trac:
Points: 1 to 2

Ok, this is fixed in origin/master. It's going to need the transifex magic spells to pull in the .properties strings to build an .xpi that works with it though..

s/who's popup/whose popup/

s/webppages/webpages/ (one could also argue it should be 'web pages')

Trac:
Status: needs_review to assigned
Owner: koryk to mikeperry

Trac:
Actualpoints: N/A to 2
Pointsdone: N/A to 2
Actualpointsdone: N/A to 2

FYI: Fixed those typos in origin/master.

Trac:
Status: assigned to closed
Resolution: None to fixed

closed

changed time estimate to 16h

added 16h of time spent

mentioned in issue #2513 (closed)

mentioned in issue tpo/applications/tor-browser#40197