Opened 6 years ago

Closed 6 years ago

#11116 closed defect (fixed)

windows/gitian-pluggable-transports.yml downloads argparse

Reported by: dcf Owned by: erinn
Priority: Medium Milestone:
Component: Applications/Tor bundles/installation Version:
Severity: Keywords: tbb-3.5, MikePerry201403R
Cc: coderman, mikeperry, gk, kpdyer Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

coderman on IRC noticed that the windows obfsproxy build downloads argparse (during "build", not "prep"):

Processing dependencies for obfsproxy==unknown
Searching for argparse
Reading https://pypi.python.org/simple/argparse/
Application tried to create a window, but no driver could be loaded.
Make sure that your X server is running and that $DISPLAY is set correctly.
err:systray:initialize_systray Could not create tray window
fixme:toolhelp:CreateToolhelp32Snapshot Unimplemented: heap list snapshot
fixme:toolhelp:Heap32ListFirst : stub
Best match: argparse 1.2.1
Downloading http://argparse.googlecode.com/files/argparse-1.2.1.tar.gz#md5=2fbef8cb61e506c706957ab6e135840c
Processing argparse-1.2.1.tar.gz

Now, the fact that setuptools may try to download dependencies is #10847, which we should try to inhibit by setting the http_proxy and https_proxy environment variables.

But apart from that, why did the descriptor start downloading argparse, when it didn't use to happen, and when the windows build uses Python 2.7, which includes argparse as standard? It started being downloaded in 8f8a4cd59b, which started calling the obfsproxy "install" target where only "py2exe" was called before.

   LD_PRELOAD= $INSTPYTHON setup_py2exe.py py2exe
+  LD_PRELOAD= $INSTPYTHON setup.py install

It seems "py2exe" is able to find the standard library argparse dependency, but "install" is not. Hence setuptools attempts to download it.

I attach a candidate patch that builds argparse in the windows descriptor, just like in the mac and linux descriptors, even though it wouldn't be necessary if "install" could find the standard library version. This patch works, but is not so elegant and there might be a better way.

Child Tickets

Attachments (1)

0001-Install-argparse-in-windows-pluggable-transports.patch (2.4 KB) - added by dcf 6 years ago.
Candidate patch that builds argparse in the windows descriptor.

Download all attachments as: .zip

Change History (3)

Changed 6 years ago by dcf

Candidate patch that builds argparse in the windows descriptor.

comment:1 Changed 6 years ago by mikeperry

Keywords: MikePerry201403R added
Status: newneeds_review

comment:2 Changed 6 years ago by mikeperry

Resolution: fixed
Status: needs_reviewclosed

This was merged for TBB 3.5.3 and 3.6-beta-1.

Note: See TracTickets for help on using tickets.