Opened 6 years ago

Closed 2 years ago

#11148 closed enhancement (fixed)

add UPLOAD action to HS_DESC control event

Reported by: dave2008 Owned by:
Priority: Very Low Milestone: Tor: unspecified
Component: Core Tor/Tor Version: Tor: 0.2.7
Severity: Normal Keywords:
Cc: nick, asn Actual Points:
Parent ID: Points: small
Reviewer: Sponsor: SponsorR-can

Description

This is the implementation for #11147.

Public branch:
https://github.com/houqp/tor/tree/hs_upload

Child Tickets

Change History (22)

comment:1 Changed 6 years ago by nickm

Milestone: Tor: 0.2.6.x-final
Status: newneeds_review

comment:2 Changed 5 years ago by nickm

I like most of this except the part where it shares the HS_DESC event with clients. IMO there should be a separate HIDSERV event, or something. That way we don't confuse client events with server events.

Also: is the right event to be sending "We uploaded to the directories"? Should there instead/also be an event that says when the uploads have succeeded?

comment:3 Changed 5 years ago by nickm

Status: needs_reviewneeds_revision

comment:4 Changed 5 years ago by nickm

Milestone: Tor: 0.2.6.x-finalTor: 0.2.???

We can take these when they're revised, I think, but there's no need to block a release on revising them.

comment:5 Changed 5 years ago by nickm

Milestone: Tor: 0.2.???Tor: 0.2.7.x-final

These might also be worth looking at in 0.2.7

comment:6 Changed 5 years ago by nickm

Keywords: 027-triaged-1-in added

Marking some tickets as triaged-in for 0.2.7 based on early triage

comment:7 Changed 5 years ago by isabela

Keywords: SponsorR added
Points: small
Priority: normaltrivial
Version: Tor: 0.2.7

comment:8 Changed 4 years ago by meejah

From my perspective, the most-useful event would be "I have successfully uploaded enough descriptors that the hidden-service can now be used".

Other controllers may want finer-grained knowledge (use-cases?) I suppose.

comment:9 Changed 4 years ago by nickm

Milestone: Tor: 0.2.7.x-finalTor: 0.2.8.x-final

comment:10 Changed 4 years ago by nickm

Keywords: 028-triaged added

comment:11 Changed 4 years ago by nickm

Keywords: SponsorR removed
Sponsor: SponsorR

Bulk-replace SponsorR keyword with SponsorR sponsor field in Tor component.

comment:12 Changed 4 years ago by dgoulet

Keywords: 027-triaged-1-in removed

comment:13 Changed 4 years ago by nickm

Keywords: pre028-patch added

comment:14 Changed 4 years ago by nickm

(Stepping back, what's the application here? What applications would like to use this feature?)

comment:15 Changed 4 years ago by nickm

Milestone: Tor: 0.2.8.x-finalTor: 0.2.???

It is impossible that we will fix all 261 currently open 028 tickets before 028 releases. Time to move some out. This is my first pass through the "needs_revision" and "needs_information" tickets, looking for things to move to ???.

Note that in most cases, if these tickets get the requested revisions done in time for the 0.2.8 merge window, they could get considered for review and merge in 0.2.8.

comment:16 Changed 4 years ago by dgoulet

Sponsor: SponsorRSponsorR-can

Move those from SponsorR to SponsorR-can.

comment:17 Changed 3 years ago by teor

Milestone: Tor: 0.2.???Tor: 0.3.???

Milestone renamed

comment:18 Changed 3 years ago by nickm

Keywords: tor-03-unspecified-201612 added
Milestone: Tor: 0.3.???Tor: unspecified

Finally admitting that 0.3.??? was a euphemism for Tor: unspecified all along.

comment:19 Changed 2 years ago by nickm

Keywords: tor-03-unspecified-201612 removed

Remove an old triaging keyword.

comment:20 Changed 2 years ago by nickm

Keywords: 028-triaged removed

comment:21 Changed 2 years ago by nickm

Keywords: pre028-patch removed

comment:22 Changed 2 years ago by dgoulet

Resolution: fixed
Severity: Normal
Status: needs_revisionclosed
Note: See TracTickets for help on using tickets.