Opened 6 years ago

Closed 5 years ago

Last modified 5 years ago

#11175 closed defect (fixed)

Remove “About Torbutton…” entry from onion menu

Reported by: lunar Owned by: tbb-team
Priority: Low Milestone:
Component: Applications/Tor Browser Version:
Severity: Keywords: tbb-usability, tbb-torbutton, TorBrowserTeam201502, GeorgKoppen201502R
Cc: gk, griffin@… Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Now that Torbutton is fully integrated in the Tor Browser, I think the “About Torbutton…” entry in the onion menu should be removed. What does it bring to users except potential confusion: it says a different version number than the browser.

An alternative I can think of is to replace it with a “About Tor Browser…” that could open “about:tor”, but I don't think an additional pop-up is worthwhile.

Child Tickets

Attachments (1)

11175.patch (4.3 KB) - added by saint 5 years ago.

Download all attachments as: .zip

Change History (13)

comment:1 Changed 6 years ago by gk

Cc: gk added

Removing that item sounds good to me (+ updating the one reachable via Tools -> Add-ons -> Extensions -> Torbutton (right-click) -> About). There is already an "About Tor Browser" option in the Help menu. No need to duplicate it in an extension toolbar button menu.

comment:2 Changed 5 years ago by erinn

Component: TorBrowserButtonTor Browser
Keywords: tbb-torbutton added
Owner: changed from mikeperry to tbb-team

comment:3 Changed 5 years ago by saint

Cc: griffin@… added

Changed 5 years ago by saint

Attachment: 11175.patch added

comment:4 Changed 5 years ago by saint

Status: newneeds_review

Removed the "About Torbutton" menu entry in src/chrome/content/popup.xul, as well as the corresponding src/chrome/content/about.xul file. Please review the above patch.

comment:5 Changed 5 years ago by gk

Keywords: TorBrowserTeam201502R added

comment:6 in reply to:  4 ; Changed 5 years ago by gk

Replying to saint:

Removed the "About Torbutton" menu entry in src/chrome/content/popup.xul, as well as the corresponding src/chrome/content/about.xul file. Please review the above patch.

Looks good. I'd like to keep the old contributors around, though (I'd even have updating that list somewhere on my ToDo list). Having them buried (but still visible) via Tools -> Add-ons -> Extensions -> Torbutton (right-click) -> About seems like a good idea to me. Do you like updating your patch in this regard (the respective contributor tags in the install.rdf are just missing, don't forget to add your name while you are at it ;) )?

comment:7 Changed 5 years ago by gk

Keywords: GeorgKoppen201502R added

comment:8 in reply to:  6 ; Changed 5 years ago by saint

Replying to gk:

Looks good. I'd like to keep the old contributors around, though (I'd even have updating that list somewhere on my ToDo list). Having them buried (but still visible) via Tools -> Add-ons -> Extensions -> Torbutton (right-click) -> About seems like a good idea to me. Do you like updating your patch in this regard (the respective contributor tags in the install.rdf are just missing, don't forget to add your name while you are at it ;) )?

Right-clicking acts the same as clicking it, so it would still be an extra entry. What do you think about adding the contributors as their own tab in Preferences?

comment:9 Changed 5 years ago by mikeperry

Ok, I put this patch in https://gitweb.torproject.org/mikeperry/torbutton.git/commit/?h=1.8-next&id=68d6c7137ab1b3904144dd9f6532a85cca9c0ca9.

I am not so convinced that we need to keep this UI pane around. I merely hid it for now in case we want to put this somewhere else.

In reality, we should have a contributor pane for all of Tor Browser IMO, but I think that may also be a separate bug.

comment:10 Changed 5 years ago by mikeperry

Resolution: fixed
Status: needs_reviewclosed

Ok, this menu is now gone for 4.5a4.

comment:11 Changed 5 years ago by mikeperry

Keywords: TorBrowserTeam201502 added; TorBrowserTeam201502R removed

comment:12 in reply to:  8 Changed 5 years ago by gk

Replying to saint:

Replying to gk:

Looks good. I'd like to keep the old contributors around, though (I'd even have updating that list somewhere on my ToDo list). Having them buried (but still visible) via Tools -> Add-ons -> Extensions -> Torbutton (right-click) -> About seems like a good idea to me. Do you like updating your patch in this regard (the respective contributor tags in the install.rdf are just missing, don't forget to add your name while you are at it ;) )?

Right-clicking acts the same as clicking it, so it would still be an extra entry.

I don't think so. Clicking on it in Tools -> Add-ons -> Extensions just selects Torbutton.

Mike: I was not in favor of keeping the pane around. Moving the contributors to the install.rdf seemed still like a good compromise to me. That said having just one contributors pane for all of Tor Browser might even be better. I've filed #14906 for it.

Note: See TracTickets for help on using tickets.