Changes between Initial Version and Version 1 of Ticket #11190, comment 7


Ignore:
Timestamp:
Apr 12, 2014, 12:54:42 AM (5 years ago)
Author:
yawning
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #11190, comment 7

    initial v1  
    22> Replying to [comment:5 yawning]:
    33> > I'm not sure how many python scripts we actually ship in TBB 3.6, but the correct fix for obfsproxy is in my userrepo as `bug_11190`.  Other PTs that contain `#!/usr/bin/python` should also be changed, since it's fairly clear that the build process doesn't cause distutils/setuptools to modify all of the scripts.
     4> I think it's just due to some setuptools weirdness in how obfsproxy is set up. The "obfsproxy" executable isn't actually mentioned in setup.py, and it should be. If it were instead listed under `scripts`, then its shebang would be modified appropriately.
     5
    46
    57Well that would explain why the descriptor is just copying the script from the source tree.  asn is there any reason why this is the case?
    68
    79To be honest I think doing both (changing the shebang to be more explicity) *and* fixing setup.py is the right thing to do here, if only because I hate having bin/obfsproxy being perpetually stuck in my git status as changed (Yes, I could just stick it in `.git/info/exclude` since it's unlikely to change much, but I shouldn't have to).
     10
     11(Edit: Fixed quoting failure)