Opened 4 years ago

Closed 4 years ago

#11232 closed defect (fixed)

Run without warnings from clang-3.4 dynamic analyzer tools

Reported by: nickm Owned by:
Priority: Medium Milestone: Tor: 0.2.5.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: tor-relay, 025-triaged
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Clang 3.4 has some nifty dynamic analyzer tools that we should run on Tor to kill off any undefined behaviors, addressing violations, etc. We'll have some false positives to squash.

The Python folks have a guide for building the tools if you don't have 'em: http://docs.python.org/devguide/clang.html

Child Tickets

Change History (11)

comment:1 Changed 4 years ago by nickm

Status: newneeds_review

See branch "bug11232" in my public repository. 2aea6ca3260cee82 is a backport candidate.

comment:2 Changed 4 years ago by nickm

(That branch fixes the warnings in the unit tests, and from running a client, that appear with '-fsanitize=undefined,address'. I didn't see any further warnings from running a test network with chutney, but I'm not sure I would have found them if I had.)

comment:3 Changed 4 years ago by nickm

Keywords: 025-triaged added

comment:4 Changed 4 years ago by andrea

This all looks fine to me. Merge at will.

comment:5 Changed 4 years ago by nickm

Milestone: Tor: 0.2.5.x-finalTor: 0.2.4.x-final

Merged. We should consider a backport of 2aea6ca3260cee82 and the changes file in 61090bb64

comment:6 Changed 4 years ago by nickm

Consider for backport:

  • 2aea6ca3260cee82a60168c047f4d0cc71f7c652
  • dfdeb6418d3d99e6e9099a3ad8ca83c206b52bdc

Those are the undefined behavior ones; others we can ignore for the nonce.

comment:7 Changed 4 years ago by nickm

Keywords: nickm-backport-02422 added

Adding a tag for tickets I think we should backport into 0.2.4.22. Omitting ones where I said "unsure"

comment:8 Changed 4 years ago by arma

These don't actually hurt anything right? I'm inclined to leave them.

comment:9 Changed 4 years ago by arma

anything in practice on actual archs that actual users use, I mean

comment:10 Changed 4 years ago by nickm

I believe not.

comment:11 Changed 4 years ago by nickm

Keywords: nickm-backport-02422 removed
Milestone: Tor: 0.2.4.x-finalTor: 0.2.5.x-final
Resolution: fixed
Status: needs_reviewclosed

Okay, no backport to 0.2.4.

Note: See TracTickets for help on using tickets.