Opened 6 years ago

Closed 6 years ago

#11279 closed defect (fixed)

Quiet some warns for protocol errors setting rendezvous points

Reported by: arma Owned by:
Priority: Medium Milestone: Tor: 0.2.5.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: easy, tor-relay
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

In https://lists.torproject.org/pipermail/tor-relays/2014-March/004031.html we see a relay operator reporting lots of "Invalid length on ESTABLISH_RENDEZVOUS" errors.

The code in question is in rend_mid_establish_rendezvous():

  if (request_len != REND_COOKIE_LEN) {
    log_warn(LD_PROTOCOL, "Invalid length on ESTABLISH_RENDEZVOUS.");

Seems to me that log_warn should be a log_protocol_warn, since there's nothing the relay operator should do about some client not obeying the protocol.

Are there other log_warns in this vicinity that we should change also? I looked around a bit and didn't see others.

Child Tickets

Change History (1)

comment:1 Changed 6 years ago by nickm

Resolution: fixed
Status: newclosed

Agreed; trivial change done in 07eb481492ddd24f403ef75db65a00b38f2b5d92.

Note: See TracTickets for help on using tickets.