Skip to content
Snippets Groups Projects
Closed (moved) Extended ORPort and TransportControlPort spec (#196) is "Finished" but not "Closed"
  • View options
  • Extended ORPort and TransportControlPort spec (#196) is "Finished" but not "Closed"

    • View options
  • Closed (moved) created by Alexander Hansen Færøy

    Attributes

    Status

    Done

    Assignees

    None

    Labels

    None

    Milestone

    Tor: unspecified

    Dates

    Start: None

    Due: None

    Time tracking

    No estimate or time spent

    Activity

    • All activity
    • Comments only
    • History only
    • Newest first
    • Oldest first
    • Georg Koppen

      The mockup looks good to me. I think we could reuse our local Changelog page for the "View Changelog" item. That is, we could load that one instead of making a request to a remote page (which would need to be kept in sync with the Changelog we ship).

    • Antonela

      Replying to gk:

      The mockup looks good to me. I think we could reuse our local Changelog page for the "View Changelog" item. That is, we could load that one instead of making a request to a remote page (which would need to be kept in sync with the Changelog we ship).

      Agreed! what is that url nowadays? We can style it to match the styleguide and we could be done. Do we have an .onion for it too?

    • Georg Koppen

      Replying to antonela:

      Replying to gk:

      The mockup looks good to me. I think we could reuse our local Changelog page for the "View Changelog" item. That is, we could load that one instead of making a request to a remote page (which would need to be kept in sync with the Changelog we ship).

      Agreed! what is that url nowadays? We can style it to match the styleguide and we could be done. Do we have an .onion for it too?

      What do you mean? I was talking about avoiding a remote URL and using a local one instead. Today we have about:tbupdate we could split that up and create a new URL, say, about:changelog or something for the "View Changelog" item.

    • Antonela

      Replying to gk:

      Today we have about:tbupdate we could split that up and create a new URL, say, about:changelog or something for the "View Changelog" item.

      Sorry for the confusion, you are right. Having something like about:changelog is ideal. So, we can have the same layout we have in about:tor at about:tbupdate but with a new title.

      And then, advanced (and curious) users can go deep on the changes clicking on View Changelog.

      Do we need a mockup for about:changelog? is that markdown/markup?

      Orthogonal: Do you think we need/should have a place to have it on our website? I think that could be useful to 1. have release notes outside the blog 2. have a centralized place to look for this notes.

      Firefox have https://www.mozilla.org/en-US/firefox/64.0/releasenotes/

    • Georg Koppen

      Replying to antonela:

      Replying to gk:

      Today we have about:tbupdate we could split that up and create a new URL, say, about:changelog or something for the "View Changelog" item.

      Sorry for the confusion, you are right. Having something like about:changelog is ideal. So, we can have the same layout we have in about:tor at about:tbupdate but with a new title.

      Yes, something like that.

      And then, advanced (and curious) users can go deep on the changes clicking on View Changelog.

      Do we need a mockup for about:changelog? is that markdown/markup?

      Dunno. I have not thought about how fancy we want to have it. My first intuition is to just "cut out" what we have on about:tbupdate today and display it similarly on about:changelog...

      Orthogonal: Do you think we need/should have a place to have it on our website? I think that could be useful to 1. have release notes outside the blog 2. have a centralized place to look for this notes.

      Firefox have https://www.mozilla.org/en-US/firefox/64.0/releasenotes/

      Yup, sounds like a good idea to me. Do you mind opening a ticket (bonus points for suggestions where on the website this should be shown. :) )?

    • Georg Koppen

      Trac:
      Keywords: N/A deleted, TorBrowserTeam201903 added
      Cc: N/A to mcs, brade

    • Mark Smith

      Kathy and I are starting to look at implementation for this ticket and we have a few UX questions:

      1. Should the post-update about:tor page that includes the Tor Browser has been updated text be displayed one time and one time only? We assume the answer is yes, but that does mean there will be no way for the user to return to that variation of about:tor once they close it or navigate away.
      2. Should we include the For the most up-to-date information about this release, visit our website. text and link on the new about:changelog page? Kathy and I think we should so that users can access that link in the future by opening about:changelog (after they close or navigate away from the post-update about:tor page).
      3. Should the top-right corner of about:tor always include the View Changelog link, or should that only be visible in the post-update about:tor page? Always including it seems preferable because that will provide a way for users to see the changelog later from within the browser.

      Trac:
      Status: new to needs_information

    • Antonela

      Replying to mcs:

      Happy to have you both working on it :)

      1. Exactly, you right. One time and one time only. Next time they open the browser, or next time they open about:tor we should have the regular about:tor.

      2. Yes! about:changelog is the place where we are going to list change log lists. We discussed with Geko the possibility of including it in some place of the website. I owe that ticket. But, it is not related with this ticket scope. Maybe, that copy needs to be updated as well, since we are not going to link to the website, yet. Any suggestion?

      3. I think that we should include it always. Could we keep it?

      Now my turn :)

      Do you need a mockup for about:changelog? Is that html/markdown? Do you want to put the data there and could I work on the style? Let me know what is better for you.

      Thanks!

    • Antonela

      Replying to gk:

      Yup, sounds like a good idea to me. Do you mind opening a ticket (bonus points for suggestions where on the website this should be shown. :) )?

      Done #29664 (moved), thanks!

    • Mark Smith

      Replying to antonela:

      1. Yes! about:changelog is the place where we are going to list change log lists. We discussed with Geko the possibility of including it in some place of the website. I owe that ticket. But, it is not related with this ticket scope. Maybe, that copy needs to be updated as well, since we are not going to link to the website, yet. Any suggestion?

      The old about:tbupdate page links to the blog posting for the release. I think we can keep that for now. Since the URL is retrieved from a server during the update process, it will be easy to change it later if the website gains a nice changelog page.

      1. I think that we should include it always. Could we keep it?

      Yes, will do.

      Now my turn :)

      Do you need a mockup for about:changelog? Is that html/markdown? Do you want to put the data there and could I work on the style? Let me know what is better for you.

      I am not sure what kind of styling you have in mind, but the page is XHTML. Look here: https://gitweb.torproject.org/tor-browser.git/tree/browser/base/content/abouttbupdate?h=tor-browser-60.5.1esr-8.5-1 One of the current limitations is that the change log itself is extracted from a plain text file: the contents of the id="changelog"

      within the aboutTBUpdate.xhtml file are replaced with the first portion of the following file: https://gitweb.torproject.org/builders/tor-browser-build.git/tree/projects/tor-browser/Bundle-Data/Docs/ChangeLog.txt

      That means it will be difficult to apply different styles to different parts of the list of changes.

      Trac:
      Status: needs_information to new

    • Antonela

      Trac:
      about_changelog

    • Antonela

      Replying to mcs:

      I am not sure what kind of styling you have in mind, but the page is XHTML.

      Nothing too much complicated. Something close to:

      ![https://trac.torproject.org/projects/tor/raw-attachment/ticket/29440/about%3Achangelog.jpg, 700px](https://trac.torproject.org/projects/tor/raw-attachment/ticket/29440/about%3Achangelog.jpg, 700px)

      Any monospace system font is elegant for the changelog copy. Then, you already have our brand font loaded. What do you think?

    • Antonela

      Do you think this is a good place to ask for feedback / report a bug too? If yes, should we link users to our contact page?

      https://lektor-staging.torproject.org/tpo/staging/contact/

    • Mark Smith

      Replying to antonela:

      Replying to mcs:

      I am not sure what kind of styling you have in mind, but the page is XHTML.

      Nothing too much complicated. Something close to:

      ![https://trac.torproject.org/projects/tor/raw-attachment/ticket/29440/about%3Achangelog.jpg, 700px](https://trac.torproject.org/projects/tor/raw-attachment/ticket/29440/about%3Achangelog.jpg, 700px)

      Any monospace system font is elegant for the changelog copy. Then, you already have our brand font loaded. What do you think?

      Given our current process, it seems risky to depend too much on the format of the ChangeLog.txt file (we would need to parse it to pull the version and release date into separate fields). But we will try to style the page in a way that is similar to what you propose.

    • Mark Smith

      Replying to antonela:

      Do you think this is a good place to ask for feedback / report a bug too? If yes, should we link users to our contact page?

      https://lektor-staging.torproject.org/tpo/staging/contact/

      I am not sure if the about:changelog page is a good place for that link. about:tor seems like a better place, and in fact we already have the Tor Browser Manual link there. Maybe we should make sure the manual includes info on how to get help and how to report a bug.

    • Antonela

      Replying to mcs:

      I am not sure if the about:changelog page is a good place for that link. about:tor seems like a better place, and in fact we already have the Tor Browser Manual link there. Maybe we should make sure the manual includes info on how to get help and how to report a bug.

      Yep, good idea. Thanks!

    • Georg Koppen

      Tickets on our radar for 8.5

      Trac:
      Keywords: N/A deleted, tbb-8.5 added

    • Mark Smith

      Trac:
      bug28440-about-tor

    • Mark Smith

      about:tor after update