Missing include breaks build of tor-fw-helper in 0.2.5.3

If you use "./configure --enable-upnp && make", build with break on missing siphash.h in tor-fw-helper:

  CC       src/tools/tor-fw-helper/src_tools_tor_fw_helper_tor_fw_helper-tor-fw-helper.o
In file included from src/tools/tor-fw-helper/tor-fw-helper.c:25:
./src/common/container.h:10:21: error: siphash.h: No such file or directory

Seems that -I$(srcdir)/src/ext is required somewhere.

changed milestone to %Tor: 0.2.5.x-final

added component::core tor/tor milestone::Tor: 0.2.5.x-final priority::medium resolution::fixed status::closed tor-client type::defect version::tor 0.2.5.3-alpha labels

Trac:
Keywords: N/A deleted, tor-client added
Milestone: N/A to Tor: 0.2.5.x-final

Possible bugfix in branch "bug11278"

Edit: whoops; wrong ticket.

Trac:
Status: new to needs_review

Does my branch "bug11296" fix this for you?

Yes, it fixes the problem with building tor-fw-helper.

The build breaks on generating documentation, which I can't quite understand how it can be affected by the added include from patch (this does not occur without --enable-upnp):

  GEN    doc/tor-resolve.1
  GEN    doc/torify.1
config.status: error: cannot find input file: doc/torify.1.in
make[1]: *** [doc/torify.1] Error 1
make[1]: Leaving directory `/home/ondro/tmp/tor.clean'
make: *** [all] Error 2

I tried to randomly insert the include at various places, but still get the failure with documentation generation.

When crosscompiling using openwrt buildroot, it gives wholly different and more confusing error about automake-1.13 missing, just after applying the bug11296 branch patch. I'll try looking into a bit more, but currently I can't see a specific cause for it right now.

I've merged bug11296, and opened #11321 (moved) to track the other issue. I have a fix for that too.

Trac:
Status: needs_review to closed
Resolution: N/A to fixed

closed

moved to tpo/core/tor#11296 (closed)