Opened 5 years ago

Closed 5 years ago

#11306 closed defect (fixed)

connection_mark_all_noncontrol_connections() handles orconns wrongly

Reported by: andrea Owned by: andrea
Priority: Medium Milestone: Tor: 0.2.5.x-final
Component: Core Tor/Tor Version: Tor: 0.2.5.3-alpha
Severity: Keywords: tor-client, 025-triaged, nickm-review-0254
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

This should call the right connection_or_close_*() function rather than connection_mark_for_close(). This can readily be observed by starting a client and letting it open some channels, then adding DisableNetwork 1 to the config and reloading, leading to warnings in the log like this:

Mar 24 16:21:16.000 [warn] connection_mark_for_close_(): Something tried to close an or_connection_t without going through channels at src/or/connection.c:2343
Mar 24 16:21:58.000 [warn] connection_mark_for_close_(): Something tried to close an or_connection_t without going through channels at src/or/connection.c:2343

Created pursuant to connection_mark_for_close() audit task #7472.

Child Tickets

Change History (5)

comment:1 Changed 5 years ago by nickm

Keywords: tor-client 025-triaged added

comment:2 Changed 5 years ago by nickm

Status: newassigned

comment:3 Changed 5 years ago by andrea

Status: assignedneeds_review

This is now fixed in my bug11306 branch, along with another bug discovered while testing that was causing warnings about duplicate calls to connection_mark_for_close() on listener connections when setting DisableNetwork on a relay.

comment:4 Changed 5 years ago by nickm

Keywords: nickm-review-0254 added

comment:5 Changed 5 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

Looks good; merged!

Note: See TracTickets for help on using tickets.