Opened 10 years ago

Closed 7 years ago

#1134 closed defect (fixed)

Our configure.in still handles --with-tor-group

Reported by: arma Owned by:
Priority: Low Milestone: Tor: 0.2.3.x-final
Component: Applications/Tor bundles/installation Version: 0.2.2.5-alpha
Severity: Keywords: easy
Cc: arma, nickm Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description (last modified by nickm)

Even though the Group torrc option is obsolete as of 0.2.0.x, our
configure.in script still handles --with-tor-group

Then our contributed tor.spec file still tries to pass in things like
%configure --with-tor-user=%{toruser} --with-tor-group=%{torgroup}

Also, contrib/osx/Tor launches tor with the --group option, which Tor
ignores:

$TORCMD -f "$TORCONF" --runasdaemon 1 --pidfile "$TORPID" --data

directory "$TORDATA" --user "$TORUSER" --group "$TORGROUP" --log "notice file $T
ORLOG" &

We should change the packages so they stop trying to call the obsolete
Group config option, and change configure.in to either ignore it or complain.

[Automatically added by flyspray2trac: Operating System: All]

Child Tickets

Change History (3)

comment:1 Changed 9 years ago by nickm

Description: modified (diff)
Milestone: Tor: 0.2.3.x-final

comment:2 Changed 8 years ago by nickm

Keywords: easy added

comment:3 Changed 7 years ago by Sebastian

Resolution: Nonefixed
Status: newclosed

I think this bug might be partially wrong: the tor.spec files need to know the groupname which they'll create for the tor user, if they need to make it. So just removing the --with-tor-group thing doesn't help at all here. I think all we need to do is make sure nobody calls tor with the --group option anymore.

I think that means we're done here, because contrib/osx/Tor is gone, and I couldn't find anything else that uses --group.

Please reopen if you disagree

Note: See TracTickets for help on using tickets.