Opened 4 years ago

Last modified 18 months ago

#11374 needs_revision defect

fix tor lockfile checking bug

Reported by: dave2008 Owned by: dave2008
Priority: Medium Milestone:
Component: Core Tor/Chutney Version:
Severity: Normal Keywords:
Cc: nickm Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

I previously had a misconception that lockfile got removed every time tor exits :(

This patch checks the state of lockfile properly.

branch:
https://github.com/houqp/chutney/tree/lock_fix

Child Tickets

Change History (7)

comment:1 Changed 4 years ago by arma

Which lockfile? I think Tor does try to unlink the lockfile in its datadir when it exits -- that's what it's for.

comment:2 Changed 4 years ago by dave2008

Yeah, the "lock" file in datadir :)

I checked the source, in main.c, release_lockfile(), it only unlocks the file. Did it get unlinked in other places?

comment:3 Changed 3 years ago by nickm

Status: newneeds_review

It looks like this branch contains several other patches as well?

comment:4 Changed 3 years ago by dave2008

Yes, I don't remember why I put them into the same branch though :(

The rest are only refactories that moves code around to git rid of global variables. Should I create a separate ticket for it?

comment:5 in reply to:  4 Changed 20 months ago by teor

Severity: Normal
Status: needs_reviewneeds_revision

Replying to dave2008:

Yes, I don't remember why I put them into the same branch though :(

The rest are only refactories that moves code around to git rid of global variables. Should I create a separate ticket for it?

Yes please!

comment:6 Changed 18 months ago by nickm

Owner: changed from nickm to dave2008
Status: needs_revisionassigned

comment:7 Changed 18 months ago by nickm

Status: assignedneeds_revision
Note: See TracTickets for help on using tickets.