Opened 4 years ago

Closed 20 months ago

#11387 closed defect (fixed)

Can't send emails if the server has non-fqd restriction

Reported by: ice9 Owned by: ioerror
Priority: Immediate Milestone:
Component: Applications/TorBirdy Version:
Severity: Normal Keywords: outgoing, send
Cc: gk, ter.one.leeboi@… Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

When trying to send an email, Thunderbird sends "helo=<127.0.0.1>" instead of the fully qualified domain name so if the server has restriction it will fail to send it.

Child Tickets

Attachments (1)

0001-Fixed-bug-11387.patch (696 bytes) - added by ice9 4 years ago.
Bug fix patch

Download all attachments as: .zip

Change History (10)

comment:1 Changed 4 years ago by gk

Cc: gk added

I have the same issue which is in fact a PITA. So, yes, a solution to this problem would be nice.

Changed 4 years ago by ice9

Attachment: 0001-Fixed-bug-11387.patch added

Bug fix patch

comment:2 Changed 4 years ago by ice9

Status: newneeds_review

comment:3 Changed 4 years ago by ice9

"mail.smtpserver.default.hello_argument": "127.0.0.1"

That line will send 127.0.0.1 as the domain name to the mail server so server will reject that domain.
Also this doesn't leak the sender's IP so it's useless line.

comment:4 Changed 4 years ago by sukhbir

Hi ice9. Thanks for the patch. However, doing this patch requires more work because if we remove the above line, then this option is removed for all users. Basically, we have to add an option for allowing this preference to be toggled. This involves doing many things so we should discuss it if you want to continue working on it :)

comment:5 Changed 4 years ago by gk

Why not just letting all users send things like "host.example.com"? As long as every Torbirdy user is sending the same it does not matter what is being sent (apart from more or less broken setups due to it).

comment:6 Changed 4 years ago by ice9

Thanks for your reply and yes I want to continue working on it :).

Without using this variable "mail.smtpserver.default.hello_argument" email headers shows Received: from [0.0.0.0]

Using that variable with following values:
"" and it works fine showing Received: from [0.0.0.0] in the email headers
"mail.example.com" works too showing Received: from mail.example.com

So which one do you see it's the right choice it should be hard coded like the original value "127.0.0.1" or set in the preferences by the user like sukhbir said?

comment:7 Changed 3 years ago by leeroy

Cc: ter.one.leeboi@… added

comment:8 Changed 20 months ago by sukhbir

Severity: Normal

Related: #13006.

comment:9 Changed 20 months ago by sukhbir

Resolution: fixed
Status: needs_reviewclosed

Fixed in 0f14f38b7fad2983623157eaedc8af294eeb74fc.

-  "mail.smtpserver.default.hello_argument": "127.0.0.1",
+  "mail.smtpserver.default.hello_argument": "[127.0.0.1]",

More details here: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=812115

Thanks ice9 for reporting this.

Note: See TracTickets for help on using tickets.