Can't send emails if the server has non-fqd restriction

When trying to send an email, Thunderbird sends "helo=<127.0.0.1>" instead of the fully qualified domain name so if the server has restriction it will fail to send it.

Trac:
Username: ice9

added component::applications/torbirdy outgoing owner::ioerror priority::immediate reporter::ice9 resolution::fixed send severity::normal status::closed type::defect labels

I have the same issue which is in fact a PITA. So, yes, a solution to this problem would be nice.

Trac:
Cc: N/A to gk

Trac:
Username: ice9

0001-Fixed-bug-11387.patch

Bug fix patch

Trac:
Username: ice9

Trac:
Username: ice9
Status: new to needs_review

"mail.smtpserver.default.hello_argument": "127.0.0.1"

That line will send 127.0.0.1 as the domain name to the mail server so server will reject that domain. Also this doesn't leak the sender's IP so it's useless line.

Trac:
Username: ice9

Hi ice9. Thanks for the patch. However, doing this patch requires more work because if we remove the above line, then this option is removed for all users. Basically, we have to add an option for allowing this preference to be toggled. This involves doing many things so we should discuss it if you want to continue working on it :)

Why not just letting all users send things like "host.example.com"? As long as every Torbirdy user is sending the same it does not matter what is being sent (apart from more or less broken setups due to it).

Thanks for your reply and yes I want to continue working on it :).

Without using this variable "mail.smtpserver.default.hello_argument" email headers shows Received: from [0.0.0.0]

Using that variable with following values: "" and it works fine showing Received: from [0.0.0.0] in the email headers "mail.example.com" works too showing Received: from mail.example.com

So which one do you see it's the right choice it should be hard coded like the original value "127.0.0.1" or set in the preferences by the user like sukhbir said?

Trac:
Username: ice9

Trac:
Username: leeroy
Cc: gk to gk, ter.one.leeboi@hush.com

Related: #13006 (closed).

Trac:
Reviewer: N/A to N/A
Sponsor: N/A to N/A
Severity: N/A to Normal

Fixed in 0f14f38b7fad2983623157eaedc8af294eeb74fc.

-  "mail.smtpserver.default.hello_argument": "127.0.0.1",
+  "mail.smtpserver.default.hello_argument": "[127.0.0.1]",

More details here: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=812115

Thanks ice9 for reporting this.

Trac:
Status: needs_review to closed
Resolution: N/A to fixed

closed