Changes between Initial Version and Version 1 of Ticket #11400, comment 3


Ignore:
Timestamp:
Jul 14, 2014, 9:14:42 PM (5 years ago)
Author:
saint
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #11400, comment 3

    initial v1  
    77> How do these patches work for you? An alternative to the second patch is to increment a counter or something, and then actually die (up until the next daily refresh) after a threshold is passed.
    88
    9 I agree with your line of thinking - dying works well on a standard page because refreshing the page automatically restarts flashproxy.js.  In Cupcake's Chrome extension, things get trickier because it's running in the background until browser restart (Linux) or *system* restart (Win/OSX).  Patch #2 has tested as fine, so is being merged.  This 'bug' usually appears when someone is behind a captive portal, so it letting it attempt to poll the facilitator again seems like it would be fine.  And as you point out, this is Cupcake's default behavior currently, just with an error status.
     9I agree with your line of thinking - dying works well on a standard page because refreshing the page automatically restarts flashproxy.js.  In Cupcake's Chrome extension, things get trickier because it's running in the background until browser restart (Linux) or *system* restart (Win/OSX).  Patch 2 has tested as fine, so is being merged.  This 'bug' usually appears when someone is behind a captive portal, so it letting it attempt to poll the facilitator again seems like it would be fine.  And as you point out, this is Cupcake's default behavior currently, just with an error status.
    1010
    11 I may add a counter in addition to Patch #2 just to keep the original failsafe behavior intact.  Thank you for the patch =)
     11I may add a counter in addition to Patch 2 just to keep the original failsafe behavior intact.  Thank you for the patch =)