Opened 6 years ago

Closed 6 years ago

#11411 closed defect (fixed)

Inconsistent uptime/downtime in search results and on details page

Reported by: karsten Owned by: rndm
Priority: Medium Milestone:
Component: Metrics/Globe Version:
Severity: Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

asn writes in #11410:

In a similar note, when you search for a dead bridge, the search results page shows the 'Uptime' (11 days in Paul's case), but if you visit the bridge page it shows the 'Downtime' (4 days).

Maybe it would be better if those two indicators were consistent. Maybe in the case of a dead bridge, instead of reporting the previous uptime you could display a negative cross (the opposite of the tick sign in the 'Flags' column).

The search results page may not even show previous uptime, but "theoretical uptime if the relay or bridge was still running." Though I'm not sure. rndm?

How about simply writing -- or something in the uptime column of the search results table for non-running relays and bridges?

Child Tickets

Change History (9)

comment:1 in reply to:  description Changed 6 years ago by asn

Replying to karsten:

asn writes in #11410:

In a similar note, when you search for a dead bridge, the search results page shows the 'Uptime' (11 days in Paul's case), but if you visit the bridge page it shows the 'Downtime' (4 days).

Maybe it would be better if those two indicators were consistent. Maybe in the case of a dead bridge, instead of reporting the previous uptime you could display a negative cross (the opposite of the tick sign in the 'Flags' column).

The search results page may not even show previous uptime, but "theoretical uptime if the relay or bridge was still running." Though I'm not sure. rndm?

How about simply writing -- or something in the uptime column of the search results table for non-running relays and bridges?

Sure. That could work!

<nitpick>
However, it doesn't make it entirely clear if the bridge is down or an internal error happened. You could explain that in the tooltip, or be more funky and display a "power signal" or a "dead skull" or something else that denotes that an entity is down or dead.
</nitpick>

comment:2 Changed 6 years ago by karsten

I don't understand your nitpick. How do we know whether an entity is down or dead?

comment:3 in reply to:  2 Changed 6 years ago by asn

Replying to karsten:

I don't understand your nitpick. How do we know whether an entity is down or dead?

Sorry, it was a stupid nitpick. I just commented on the fact that -- is a bit ambiguous: it could mean that the bridge is down, or that there was an internal error in Globe. I thought that a small icon that suggested downtime might be more appropriate

In any case, I don't think anyone is going to get confused so it doesn't really matter. Worst case, just add a tooltip saying 'offline'.

comment:4 Changed 6 years ago by karsten

Ah, an "internal error" in Globe or Onionoo, not in the bridge. So, we're only talking about finding the most user-friendly way to say that a non-running bridge (or relay) has no uptime.

Here are a few options:

  1. --
  2. a small icon indicating that the relay or bridge is not running
  3. None
  4. N/A
  5. 0 seconds
  6. any of the above but with a tooltip saying 'offline'

I'd say that any of these is better than the current situation.

comment:5 Changed 6 years ago by asn

Indeed. Feel free to select whichever is most convenient for you. If a user gets confused, we can change it later.

comment:6 Changed 6 years ago by rndm

Here's a build that displays n/a if the bridge/relay is down:

http://globe.rndm.de/canary/index-11411.html

I also added a tooltip that says "offline".

btw if you want an icon, you can choose one from: http://fortawesome.github.io/Font-Awesome/icons/ (that's the icon font globe is using)

comment:7 Changed 6 years ago by karsten

Looks good with the n/a and the tooltip. I'd say let's start with that solution and put in an icon if somebody wants one. Let me know when there's a new version to deploy. Thanks!

I also created #11505 for two unrelated issues with the results list that I found while looking at the canary.

comment:8 Changed 6 years ago by rndm

I released 0.4.8 which includes the mentioned fix for this issue:

https://github.com/makepanic/globe/releases/tag/v0.4.8

comment:9 Changed 6 years ago by karsten

Resolution: fixed
Status: newclosed

Deployed 0.4.8. Looks good. Thank you! Closing.

Note: See TracTickets for help on using tickets.