Opened 5 years ago

Closed 5 years ago

#11414 closed enhancement (implemented)

jtorctl: Make TorControlConnection thread-safe

Reported by: akwizgran Owned by: n8fr8
Priority: Low Milestone:
Component: Applications/Orbot Version:
Severity: Keywords: jtorctl
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

This patch makes TorControlConnection thread-safe. In particular it prevents concurrent calls to sendAndWaitForResponse() from leaking threads.

Child Tickets

TicketTypeStatusOwnerSummary
#11415enhancementclosedn8fr8jtorctl: Throw checked exceptions instead of unchecked exceptions

Attachments (1)

jtorctl-1.patch (12.5 KB) - added by akwizgran 5 years ago.

Download all attachments as: .zip

Change History (2)

Changed 5 years ago by akwizgran

Attachment: jtorctl-1.patch added

comment:1 Changed 5 years ago by n8fr8

Resolution: implemented
Status: newclosed

BTW, these have been applied here: https://github.com/guardianproject/jtorctl and are being used in Orbot. I just haven't got perms yet to commit back to source repo on Tor's git.

Note: See TracTickets for help on using tickets.