Opened 5 years ago

Closed 5 years ago

#11415 closed enhancement (implemented)

jtorctl: Throw checked exceptions instead of unchecked exceptions

Reported by: akwizgran Owned by: n8fr8
Priority: Low Milestone:
Component: Applications/Orbot Version:
Severity: Keywords:
Cc: Actual Points:
Parent ID: #11414 Points:
Reviewer: Sponsor:

Description

jtorctl throws unchecked RuntimeExceptions if it receives an error response or malformed response from Tor - users of the library have to catch these without being warned by the API. This patch converts jtorctl's RuntimeException subclasses into IOException subclasses. This is safer for users of the library and better conveys what's happened (an IO error).

Child Tickets

Attachments (1)

jtorctl-2.patch (2.9 KB) - added by akwizgran 5 years ago.

Download all attachments as: .zip

Change History (2)

Changed 5 years ago by akwizgran

Attachment: jtorctl-2.patch added

comment:1 Changed 5 years ago by n8fr8

Resolution: implemented
Status: newclosed

BTW, these have been applied here: https://github.com/guardianproject/jtorctl and are being used in Orbot. I just haven't got perms yet to commit back to source repo on Tor's git.

Note: See TracTickets for help on using tickets.