Opened 6 years ago

Closed 6 years ago

#11437 closed defect (fixed)

Memory leak on successful PTR lookup

Reported by: nickm Owned by:
Priority: Medium Milestone: Tor: 0.2.5.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: tor-relay dns coverity 024-backport
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

In inform_pending_connections, set_exitconn_info_from_resolve() is allowed to set hostname to a newly allocated string... but nothing actually frees hostname.

This is coverity CID 1198198.

Child Tickets

Change History (4)

comment:1 Changed 6 years ago by nickm

Keywords: tor-relay added; tor-client removed
Status: newneeds_review

Fix in branch "bug11437_024" in my public repository.

comment:2 Changed 6 years ago by ln5

Looks good to me.

comment:3 Changed 6 years ago by andrea

Looks fine - merge away.

comment:4 Changed 6 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

Great; taking this into 0.2.4 and master.

Note: See TracTickets for help on using tickets.