Opened 5 years ago

Closed 4 years ago

Last modified 4 years ago

#11447 closed defect (implemented)

Find a better value for MAX_REND_FAILURES

Reported by: nickm Owned by:
Priority: Medium Milestone: Tor: 0.2.6.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: tor-hs
Cc: Actual Points:
Parent ID: #15463 Points:
Reviewer: Sponsor: SponsorR

Description

For a while, MAX_REND_FAILURES was set to 30. That's clearly wrong; in #4241 we set it to 8. But is 8 the right value? We should investigate actual failure rates and pick a value that's more in tune with what we're actually seeing in the wild.

Child Tickets

Change History (6)

comment:1 Changed 4 years ago by dgoulet

Keywords: SponsorR added

comment:2 Changed 4 years ago by asn

Parent ID: #15463

comment:3 Changed 4 years ago by asn

Status: newneeds_review

We decided that this ticket will host easy short-term changes, and we will use #15557 for more intelligent retry logic fixes.

For this ticket, please see branch bug11447 in my repo. It merely changes MAX_REND_FAILURES to 1, so that the HS has one try and one retry to make its rendezvous circuits work.

comment:4 Changed 4 years ago by dgoulet

It's very difficult to actually measure the failure rate in the wild but with #15463 being seen lately bringing this one to 1 is saner for the HS and Tor network than the current value of 8 which is a pretty high amount of retry. Without DoS defense or counter measures, keeping this one low is ideal in this context.

ACK on the patch.

comment:5 Changed 4 years ago by nickm

Milestone: Tor: 0.2.???Tor: 0.2.6.x-final
Resolution: implemented
Status: needs_reviewclosed

Taking this in 0.2.6 and later.

comment:6 Changed 4 years ago by dgoulet

Keywords: SponsorR removed
Sponsor: SponsorR
Note: See TracTickets for help on using tickets.