Torbutton New Identity error with regard to NoScript

Error reads:

Torbutton: Error clearing NoScript Temporary Permissions: TypeError: Components.classes['@maone.net/noscript-service;1'] is undefined

I'll be monitoring this bug to give feedback as needed.

I think I'm running 3.6 but I might be running the latest PT bundle. Hard to tell! Filing another bug about that :/

Thanks!

Trac:
Username: Cypherpunks

added MikePerry201410R component::applications/tor browser owner::tbb-team priority::medium reporter::Cypherpunks resolution::fixed status::closed tbb-newnym tbb-torbutton tbb-usability type::defect labels

Works for me. Does that problem persist if you donwload a clean, new version? If so, which version is affected? Does it happen regularly? Do you have special NoScript settings or are you using the default ones? Re: your version, see my comment in #11450 (closed).

Trac:
Keywords: NoScript Torbutton Error Permissions deleted, tbb-newnym added
Component: Torbutton to TorBrowserButton
Owner: N/A to mikeperry
Version: Tor: unspecified to N/A

As per #11450 (closed), version is 3.6-beta-1-Windows.

As far as I remember, NoScript was last installed fresh, then disabled (but not uninstalled), and certainly it has been disabled for a long time. It is not enabled and was not when I first got the error (I use a different toggle that blocks all java, I don't like NoScript).

I tend to install on top of previous installs. I know this can lead to bugs (peripheral issue: if advice is available regarding how to update clean without having to reinstall all plugins and re-set all settings, it would be appreciated)

I'll post again when I've run a fresh instance with NoScript disabled.

Trac:
Username: Cypherpunks

Unpacked fresh instance to new random location, ran it, went into addons, disabled NoScript, hit restart, when browser reappeared hit New Identity, same error.

Did not install any addons or plugins or alter any settings other than to disable NoScript.

For what it's worth, I use QuickJS instead as per: https://trac.torproject.org/projects/tor/wiki/doc/TorBrowserBundle3FAQ.

Trac:
Username: Cypherpunks

The problem is disabling NoScript as we are currently using a part of its code to clear temporary NoScript permissions. We should be smarter here and check whether NoScript is enabled at all (and only show the alert in this case!? or not calling eraseTemp() in the first place?). If it is disabled then there should not be any temporary NoScript permission active, and hence no need to clear the perms/show the alert.

Trac:
Keywords: N/A deleted, tbb-usability added

Trac:
Cc: N/A to Tize

Trac:
Keywords: N/A deleted, tbb-torbutton added
Component: TorBrowserButton to Tor Browser
Owner: mikeperry to tbb-team

https://github.com/loic/torbutton/commits/bug11786

Trac:
Username: loic
Cc: Tize to Tize, loic
Status: new to needs_review

Thanks for the patch. It looks good to me.

Did you test it with NoScript enabled and disabled?

I added MikePerry201410R so Mike will review and merge (assuming it looks OK to him).

Trac:
Keywords: N/A deleted, MikePerry201410R added

I did, I added an alert before and inside the if. The first one gets called always (with NoScript enabled and disabled), the second one only if NoScript is enabled.

Trac:
Username: loic

#13943 (closed) is a duplicate. I just see we had a reviewed patch? Seems this fell through the cracks.

mcs: You reviewed it. As review power = merge power go ahead. :) Otherwise I'll take care of it tomorrow.

Trac:
Cc: Tize, loic to Tize, loic, Diapolo

Fixed by 88dfaaaf325f5b86aba3d449b87320d0d962681d. Thanks again for the patch.

Trac:
Status: needs_review to closed
Resolution: N/A to fixed

closed

mentioned in issue #11786 (closed)

mentioned in issue #12471 (closed)

mentioned in issue #13943 (closed)

moved to tpo/applications/tor-browser#11449 (closed)