Opened 10 years ago

Last modified 10 years ago

#1146 closed defect (Fixed)

Tor tabs are saved and restored on crash in FF3.5 despite settings

Reported by: greenlynx Owned by:
Priority: Very High Milestone:
Component: Applications/Torbutton Version: 1.2.2
Severity: Keywords:
Cc: greenlynx, arma, mikeperry, phobos Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

I have just upgraded to Firefox 3.5.5 and have noticed a strange behviour that causes Tor tabs to be opened in non-Tor mode after a browser crash.

Torbutton Startup settings:

  • On normal startup, set Tor state to "Non-Tor"
  • On session restored startup, set Tor state to "Non-Tor"
  • Have the session store save and restore these tabs: "Tabs loaded in Non-Tor" ("Tabs loaded in Tor" is NOT checked)
  1. Open some tabs in non-Tor mode
  2. Switch to Tor-mode
  3. Open some more tabs
  4. Kill Firefox process
  5. Re-open Firefox and restore sessions if prompted

Expected result: Just open non-Tor tabs

Actual result: Opens all previous tabs (from Tor and non-Tor mode) in non-Tor mode(!)

This did not used to happen previously (using Firefox 3.x) - I could kill Firefox using 'xkill' and it would re-open with only my Non-Tor tabs restored.

Unless I'm missing something, this is a very insecure behaviour? As my Tor tabs have just been loaded in Non-Tor mode, thus violating the privacy settings?

I am using Torbutton 1.2.2 on Firefox 3.5.5, Ubuntu 9.10

[Automatically added by flyspray2trac: Operating System: All]

Child Tickets

Attachments (1)

torbutton-1.2.3-pre4.xpi (341.0 KB) - added by mikeperry 10 years ago.

Download all attachments as: .zip

Change History (5)

comment:1 Changed 10 years ago by greenlynx

I've just realised I've added this as a "low" priority item.. I think I should have made it high priority, since it seems to be a security problem.

comment:2 Changed 10 years ago by mikeperry

I believe I have fixed this. Please try out the attached xpi in the attachments tab.

Changed 10 years ago by mikeperry

Attachment: torbutton-1.2.3-pre4.xpi added

comment:3 Changed 10 years ago by greenlynx

Problem seems fixed with the attached version.

comment:4 Changed 10 years ago by mikeperry

flyspray2trac: bug closed.
Fixed will appear in 1.2.3

Note: See TracTickets for help on using tickets.