Opened 5 years ago

Closed 5 years ago

#11472 closed defect (fixed)

Onion logo and text on about:tor page may overlap in non en-US TBBs

Reported by: gk Owned by: mikeperry
Priority: Medium Milestone:
Component: TorBrowserButton Version:
Severity: Keywords: TorBrowserTeam201407, MikePerry201407R
Cc: mcs, brade Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

It seems that at least in the german TBBs the onion logo and text on about:tor may overlap.

Child Tickets

Attachments (1)

clipped-onion.PNG (6.9 KB) - added by gk 5 years ago.

Download all attachments as: .zip

Change History (5)

Changed 5 years ago by gk

Attachment: clipped-onion.PNG added

comment:1 Changed 5 years ago by mcs

Keywords: TorBrowserTeam201407 MikePerry201407R added

comment:2 Changed 5 years ago by gk

Why the 7 maxTries? Is this something experience told you while testing all currently shipped locales? If so (and even if not so :) ) could you add a respective comment for later if someone is wondering about it?

comment:3 in reply to:  2 Changed 5 years ago by mcs

Replying to gk:

Why the 7 maxTries? Is this something experience told you while testing all currently shipped locales? If so (and even if not so :) ) could you add a respective comment for later if someone is wondering about it?

It is essentially a failsafe. We added a comment; new commit is here:
https://gitweb.torproject.org/user/brade/torbutton.git/commit/0fb285c3ca6b2196406084a50b11c641f2b8406e

The comment is just before "let maxTries = 7" and it reads:

// Reduce font to 90% of previous size, repeating the process up to 7
// times.  This allows for a maximum reduction to just less than 50% of
// the original size.


comment:4 Changed 5 years ago by mikeperry

Resolution: fixed
Status: newclosed

Merged into 1.6.11.1, which should appear in 4.0-alpha-1.

Note: See TracTickets for help on using tickets.