Onion logo and text on about:tor page may overlap in non en-US TBBs

It seems that at least in the german TBBs the onion logo and text on about:tor may overlap.

added MikePerry201407R TorBrowserTeam201407 component::torbrowserbutton owner::mikeperry priority::medium resolution::fixed status::closed type::defect labels

Trac:

Fix committed: https://gitweb.torproject.org/user/brade/torbutton.git/commit/ae693b3a01e0a8f724820b997d7ab50faab1c631

Mike -- please review and merge.

Trac:
Keywords: N/A deleted, TorBrowserTeam201407, MikePerry201407R added

Why the 7 maxTries? Is this something experience told you while testing all currently shipped locales? If so (and even if not so :) ) could you add a respective comment for later if someone is wondering about it?

Replying to gk:

Why the 7 maxTries? Is this something experience told you while testing all currently shipped locales? If so (and even if not so :) ) could you add a respective comment for later if someone is wondering about it?

It is essentially a failsafe. We added a comment; new commit is here: https://gitweb.torproject.org/user/brade/torbutton.git/commit/0fb285c3ca6b2196406084a50b11c641f2b8406e

The comment is just before "let maxTries = 7" and it reads:

// Reduce font to 90% of previous size, repeating the process up to 7
// times.  This allows for a maximum reduction to just less than 50% of
// the original size.

Merged into 1.6.11.1, which should appear in 4.0-alpha-1.

Trac:
Status: new to closed
Resolution: N/A to fixed

closed