Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#11478 closed defect (fixed)

obfsproxy > 0.2.4 won't work in TBB because of missing PyYAML

Reported by: asn Owned by: erinn
Priority: Medium Milestone:
Component: Applications/Tor bundles/installation Version:
Severity: Keywords: MikePerry201404R, tbb-pt-deps
Cc: gk Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

obfsproxy > 0.2.4 needs PyYAML, and because of the way TBB building works, PyYAML needs to be installed explicitly (that is, just listing it in obfsproxy's setup.py is not sufficient to get the dependency installed during building).

We should try to include PyYAML in the TBB, because obfsproxy > 0.2.4 are the versions that support scramblesuit, connecting to outgoing proxies, etc.

Child Tickets

Attachments (1)

0001-Download-and-install-PyYAML-as-it-s-needed-for-new-o.patch (6.7 KB) - added by asn 6 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 6 years ago by asn

I attached an untested patch that might work.

comment:2 Changed 6 years ago by gk

Cc: gk added

comment:3 Changed 6 years ago by mikeperry

Keywords: MikePerry201404R added

gk - you should also feel free to look at this and merge it if you like, as soon as we get 3.6-beta-2 nailed down for sure, of course.

comment:4 Changed 6 years ago by gk

I planned to do that on Monday but was not so fast with my keyword :)

comment:5 Changed 6 years ago by gk

Resolution: fixed
Status: newclosed

Fixed in commit c088c17ba7ba93f3fcbcfc75e0c081aed2d98976. I tested it on Linux and Windows against obfsproxy 0.2.8. The Mac test is pending...

comment:6 in reply to:  5 Changed 6 years ago by gk

Replying to gk:

Fixed in commit c088c17ba7ba93f3fcbcfc75e0c081aed2d98976.

+ commit ff85a3b091dbb5956d8e1dbe03dc9d4297ddb3d1.

comment:7 Changed 6 years ago by asn

Keywords: tbb-pt-deps added
Note: See TracTickets for help on using tickets.