Opened 4 years ago

Closed 3 years ago

#11510 closed defect (fixed)

about:tor should not show green "Congratulations!" if TorLauncher is not working

Reported by: gk Owned by: mikeperry
Priority: Medium Milestone:
Component: TorBrowserButton Version:
Severity: Keywords: tbb-usability, MikePerry201405R
Cc: mcs, brade Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

On Saturday there was a user in #tor that got the "Congratulations!" page shown when about:tor was loaded but could not use the browser (TorLauncher was not available for yet unknown reasons). That should not happen. He should have been greeted with the "there is something wrong"-page instead.

Child Tickets

Change History (4)

comment:1 Changed 4 years ago by gk

Not sure if we should take into account corner cases like people using not TorLauncher but a system-wide tor. If so, we should retitle the ticket accordingly. In any case, what I'd like to avoid is a Tor Browser showing everything is okay but no tor is launched to get used for browsing.

comment:2 Changed 4 years ago by gk

Keywords: tbb-usability added

comment:3 Changed 3 years ago by mcs

Keywords: MikePerry201405R added

brade and I have a possible fix:

https://gitweb.torproject.org/user/brade/torbutton.git/commit/b9229102ee6e5098c11af49a04ca0669a0c02fd4

The basic idea is to show failure on the about:tor page when Torbutton cannot connect to the proxy (i.e., to tor). We tested it by disabling Tor Launcher.

comment:4 Changed 3 years ago by mikeperry

Resolution: fixed
Status: newclosed

Merged. Will appear in the next Torbutton tag, which will be used in 3.6.2 and 4.0-alpha.

Note: See TracTickets for help on using tickets.