about:tor should not show green "Congratulations!" if TorLauncher is not working

On Saturday there was a user in #tor that got the "Congratulations!" page shown when about:tor was loaded but could not use the browser (TorLauncher was not available for yet unknown reasons). That should not happen. He should have been greeted with the "there is something wrong"-page instead.

added MikePerry201405R component::torbrowserbutton owner::mikeperry priority::medium resolution::fixed status::closed tbb-usability type::defect labels

Not sure if we should take into account corner cases like people using not TorLauncher but a system-wide tor. If so, we should retitle the ticket accordingly. In any case, what I'd like to avoid is a Tor Browser showing everything is okay but no tor is launched to get used for browsing.

Trac:
Keywords: N/A deleted, tbb-usability added

brade and I have a possible fix:

https://gitweb.torproject.org/user/brade/torbutton.git/commit/b9229102ee6e5098c11af49a04ca0669a0c02fd4

The basic idea is to show failure on the about:tor page when Torbutton cannot connect to the proxy (i.e., to tor). We tested it by disabling Tor Launcher.

Trac:
Keywords: N/A deleted, MikePerry201405R added

Merged. Will appear in the next Torbutton tag, which will be used in 3.6.2 and 4.0-alpha.

Trac:
Status: new to closed
Resolution: N/A to fixed

closed