Opened 5 years ago

Closed 5 years ago

#11578 closed defect (fixed)

Unable to build Tor with --enable-bufferevents on Mac OS X

Reported by: rl1987 Owned by:
Priority: Medium Milestone: Tor: 0.2.5.x-final
Component: Core Tor/Tor Version: Tor: unspecified
Severity: Keywords: bufferevent
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

I am getting the following warnings and errors when attempting to build Tor (0cca8dc35a4e59944b83db0a36c7033e09fb98b4) on Mac OS X 10.9.2 system with --enable-bufferevents configuration option:

  CC       src/test/src_test_test-test_oom.o
src/test/test_oom.c:105:20: warning: incompatible pointer types passing 'buf_t *' (aka 'struct buf_t *') to parameter of type 'struct evbuffer *' [-Wincompatible-pointer-types]
  add_bytes_to_buf(TO_CONN(conn)->inbuf, in_bytes);
                   ^~~~~~~~~~~~~~~~~~~~
./src/or/or.h:1767:20: note: expanded from macro 'TO_CONN'
#define TO_CONN(c) (&(((c)->base_)))
                   ^
src/test/test_oom.c:80:36: note: passing argument to parameter 'buf' here
add_bytes_to_buf(generic_buffer_t *buf, size_t n_bytes)
                                   ^
src/test/test_oom.c:106:20: warning: incompatible pointer types passing 'buf_t *' (aka 'struct buf_t *') to parameter of type 'struct evbuffer *' [-Wincompatible-pointer-types]
  add_bytes_to_buf(TO_CONN(conn)->outbuf, out_bytes);
                   ^~~~~~~~~~~~~~~~~~~~~
./src/or/or.h:1767:20: note: expanded from macro 'TO_CONN'
#define TO_CONN(c) (&(((c)->base_)))
                   ^
src/test/test_oom.c:80:36: note: passing argument to parameter 'buf' here
add_bytes_to_buf(generic_buffer_t *buf, size_t n_bytes)
                                   ^
2 warnings generated.
  CC       src/test/src_test_test-test_options.o
  CC       src/test/src_test_test-test_pt.o
  CC       src/test/src_test_test-test_relaycell.o
  CC       src/test/src_test_test-test_replay.o
  CC       src/test/src_test_test-test_routerkeys.o
  CC       src/test/src_test_test-test_socks.o
  CC       src/test/src_test_test-test_util.o
  CC       src/test/src_test_test-test_config.o
  CC       src/test/src_test_test-test_hs.o
  CC       src/test/src_test_test-test_nodelist.o
  CC       src/test/src_test_test-test_policy.o
  CC       src/test/src_test_test-test_status.o
  CC       src/ext/src_test_test-tinytest.o
  CCLD     src/test/test
Undefined symbols for architecture x86_64:
  "_connection_buckets_note_empty_ts", referenced from:
      _help_test_bucket_note_empty in src_test_test-test_controller_events.o
  "_bucket_millis_empty", referenced from:
      _test_cntev_bucket_millis_empty in src_test_test-test_controller_events.o
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[1]: *** [src/test/test] Error 1
make: *** [all] Error 2

Child Tickets

Attachments (3)

configure.txt (13.2 KB) - added by rl1987 5 years ago.
make.txt (10.1 KB) - added by rl1987 5 years ago.
0001-Fix-warning-on-building-with-bufferevents.patch (1.4 KB) - added by gsathya 5 years ago.
(fixed commit msg)

Download all attachments as: .zip

Change History (8)

Changed 5 years ago by rl1987

Attachment: configure.txt added

Changed 5 years ago by rl1987

Attachment: make.txt added

comment:1 Changed 5 years ago by rl1987

Component: - Select a componentTor
Keywords: bufferevent added
Milestone: Tor: 0.2.5.x-final
Version: Tor: unspecified

comment:2 Changed 5 years ago by nickm

Milestone: Tor: 0.2.5.x-finalTor: 0.2.???

The bufferevent backend is pretty buggy to begin with; deferring this to whenever it is that we hammer it into shape.

comment:3 Changed 5 years ago by gsathya

Status: newneeds_review

Changed 5 years ago by gsathya

(fixed commit msg)

comment:4 Changed 5 years ago by nickm

Milestone: Tor: 0.2.???Tor: 0.2.5.x-final

comment:5 Changed 5 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

Merged to maint-0.2.5; thanks!

Note: See TracTickets for help on using tickets.