Opened 5 years ago

Closed 5 years ago

#11582 closed defect (implemented)

"getinfo address" reports wrong IP address after it has changed

Reported by: ra Owned by:
Priority: Low Milestone: Tor: 0.2.6.x-final
Component: Core Tor/Tor Version: Tor: 0.2.4.21
Severity: Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

The "getinfo address" Tor control command reports the client's IP address.
After the client's IP address has changed, the control command falsely reports the last resolved address without ever updating it.

The attached patch resets the last resolved address on an IP address change, resulting in "getinfo address" reporting the correct IP.

Child Tickets

Attachments (1)

tor_fix_changing_ip_address.patch (1.5 KB) - added by ra 5 years ago.

Download all attachments as: .zip

Change History (4)

Changed 5 years ago by ra

comment:1 Changed 5 years ago by nickm

Milestone: Tor: 0.2.6.x-final
Status: newneeds_review

Is this seriously breaking something that depends on it? If not, I'll schedule it for 0.2.6, since all of the "what's my address" code is pretty hairy.

comment:2 Changed 5 years ago by ra

I would not say that it breaks something in particular. But as "getinfo address" does not work as intended, it is hardly of any use in its current state.
On one hand I think that the patch is rather trivial, but on the other hand you have way more experience and thus can better assess the overall impact.

comment:3 Changed 5 years ago by nickm

Resolution: implemented
Status: needs_reviewclosed

Merged to master. Thanks!

Note: See TracTickets for help on using tickets.