Opened 6 years ago

Closed 6 years ago

#11608 closed defect (fixed)

The test scripts in src/test require python2.

Reported by: yawning Owned by:
Priority: Low Milestone: Tor: 0.2.5.x-final
Component: Core Tor/Tor Version: Tor: unspecified
Severity: Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:


Not sure if this is a build system problem, or a test script problem. Autoconf will pick python, python2, python3 in that order, so the scripts should be probably be written such that they run with either python2 or python3, since systems where python is python3 exist.

PYTHON=python2 ./configure sidesteps the problem on systems where python is python3, but people shouldn't have to do that.

Child Tickets

Change History (4)

comment:1 Changed 6 years ago by nickm

Milestone: Tor: 0.2.5.x-final
Priority: trivialminor

comment:2 Changed 6 years ago by nickm

Status: newneeds_review

Branch 'bug11608' in my public repo has fixes, but probably not the most pythonic ones. If somebody with better fu wants to clean them up, that would rock.

comment:3 Changed 6 years ago by yawning

The branch works for me on the system that caused me to file this, and the changes look reasonable. Thanks!

comment:4 Changed 6 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

great; merged!

Note: See TracTickets for help on using tickets.