Opened 4 years ago

Closed 4 years ago

#11622 closed defect (fixed)

libseccomp stuff breaks on arm*

Reported by: weasel Owned by: nickm
Priority: Medium Milestone: Tor: 0.2.5.x-final
Component: Core Tor/Tor Version: Tor: 0.2.5.4-alpha
Severity: Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Child Tickets

Change History (5)

comment:1 Changed 4 years ago by cypherpunks

The sanbboxing code appears very X86/X86_64 specific. Configure should enable building this file only on these architectures, rather than when libseccomp is available. Alternatively it should re researched if it is possible to use libseccomp in a more portable manner.

comment:2 Changed 4 years ago by nickm

Owner: set to nickm
Status: newassigned

comment:3 Changed 4 years ago by nickm

Current plan on these is to investigate the bug, try to finish writing the patch on each, and then evaluate whether the patch is 0.2.5 or 0.2.6 material in terms of simplicity and importance.

comment:4 Changed 4 years ago by nickm

From what I can tell, Tor compiles with my current 'arm_hax' branch. At least, the sandbox.c file compiles. Now to investigate whether it actually works, and clean it up a little

comment:5 Changed 4 years ago by nickm

Resolution: fixed
Status: assignedclosed

Okay; arm seccomp compilation is fixed, but I can't test whether it works without a more recent kernel or whatever else might be missing. Nonetheless, this is adequate to build on arm without --disable-seccomp . Closing this ticket. Please reopen if arm compilation isn't fixed, and open a new ticket if arm doesn't work with "sandbox 1".

Note: See TracTickets for help on using tickets.