Opened 6 years ago

Closed 6 years ago

#11623 closed defect (fixed)

tor-0.2.5.4-alpha and git/HEAD fail to build when --disable-buf-freelists

Reported by: blueness Owned by:
Priority: Medium Milestone: Tor: 0.2.5.x-final
Component: Core Tor/Tor Version: Tor: 0.2.5.4-alpha
Severity: Keywords: tor-relay
Cc: Actual Points:
Parent ID: #11476 Points:
Reviewer: Sponsor:

Description

When tor is configured with --disable-buf-freelists, and RUNNING_DOXYGEN is not defined, buffers.c fails to compile because total_bytes_allocated_in_chunks is defined in src/or/buffers.c within an #if ... #else block and yet used in both the #if ... #else and #else .. #endif block. By moving its declaration before the #if ... #else ... #endif, we expand its visibility to both blocks where it is used.

Child Tickets

Attachments (1)

0001-src-or-buffers.c-fix-build-when-disable-buf-freelist.patch (1.4 KB) - added by blueness 6 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 6 years ago by arma

Milestone: Tor: 0.2.5.x-final

comment:2 Changed 6 years ago by nickm

Keywords: tor-relay added
Status: newneeds_review

comment:3 Changed 6 years ago by nickm

Parent ID: #11476

comment:4 Changed 6 years ago by nickm

Andrea has a patch for this too as "bug11476". It includes fixes for the unit tests as well.

comment:5 in reply to:  4 Changed 6 years ago by blueness

Replying to nickm:

Andrea has a patch for this too as "bug11476". It includes fixes for the unit tests as well.

Which unit tests, because we have another bug about failed tests in gentoo:

https://bugs.gentoo.org/show_bug.cgi?id=509112

comment:6 Changed 6 years ago by nickm

Yes, that's the one.

comment:7 Changed 6 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

Merged that to 0.2.5.x; thanks!

Note: See TracTickets for help on using tickets.