Opened 6 years ago

Closed 5 years ago

#11659 closed enhancement (fixed)

Turn python test scripts into proper TESTS elements

Reported by: nickm Owned by:
Priority: Medium Milestone: Tor: 0.2.7.x-final
Component: Core Tor/Tor Version: Tor: 0.2.7
Severity: Keywords: tor-client, testing, autotools, 027-triaged-1-in, SponsorS
Cc: Actual Points:
Parent ID: Points: small
Reviewer: Sponsor:

Description

Right now we use the check-local target to run the python unit tests. But that's kinda janky; we could be doing better if we had them be part of TESTS, which is feasible if we do the right automake incantations.

See https://www.gnu.org/software/automake/manual/html_node/Parallel-Test-Harness.html for some tips on how to do this properly.

Child Tickets

Change History (8)

comment:1 Changed 6 years ago by nickm

Milestone: Tor: 0.2.6.x-finalTor: 0.2.???

This could get done as part of implementing prop229, and I'd like to take a refactoring patch if somebody writes one, but otherwise it's okay if this doesn't happen in 0.2.6

comment:2 Changed 5 years ago by nickm

Milestone: Tor: 0.2.???Tor: 0.2.7.x-final

These may be worth looking at for 0.2.7.

comment:3 Changed 5 years ago by nickm

See #15344 for a related ticket

comment:4 Changed 5 years ago by nickm

Status: newassigned

comment:5 Changed 5 years ago by nickm

Keywords: 027-triaged-1-in added

Marking more tickets as triaged-in for 0.2.7

comment:6 Changed 5 years ago by isabela

Keywords: SponsorS added
Points: small
Version: Tor: 0.2.7

comment:7 Changed 5 years ago by cypherpunks

#15344 is now implemented. Also close this ticket?

comment:8 Changed 5 years ago by nickm

Resolution: fixed
Status: assignedclosed

I believe so.

Note: See TracTickets for help on using tickets.