Opened 6 years ago

Closed 8 months ago

#11660 closed defect (implemented)

Make tor_spawn_background and related interfaces work the same on windows and *nix

Reported by: nickm Owned by: ahf
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-client, tor-pt, tor-fw-helper windows unix compatibility
Cc: ahf Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Have a look at the tor_spawn_background unit tests. That's sure a lot of #ifdefs! It would be nice if our portability code actually let us write code to be portable across platforms: we should fix tor_spawn_background and tor_read_all_handle to act the same across platforms.

Child Tickets

Change History (9)

comment:1 Changed 3 years ago by teor

Milestone: Tor: 0.2.???Tor: 0.3.???

Milestone renamed

comment:2 Changed 3 years ago by nickm

Keywords: tor-03-unspecified-201612 added
Milestone: Tor: 0.3.???Tor: unspecified

Finally admitting that 0.3.??? was a euphemism for Tor: unspecified all along.

comment:3 Changed 3 years ago by nickm

Cc: ahf added
Severity: Normal

ahf, I think you just did some work related to this one. Will your #21678 work cover this?

comment:4 Changed 3 years ago by ahf

Owner: set to ahf
Status: newaccepted

#21678 handles the case for tor_read_all_handle() and thus simplifies the test-cases. We need to look at tor_spawn_background() as well - especially the first parameter controlling the search path.

I'll assign this issue to myself since it makes sense that I take a look at it once I have a system running where I can test the patch for #21678.

comment:5 Changed 3 years ago by nickm

Okay, but only if you want to and have the time-- the sponsor4 stuff is more important than this.

comment:6 Changed 3 years ago by ahf

Yes, it'll be a side-project with lower priority.

comment:7 Changed 2 years ago by nickm

Keywords: tor-03-unspecified-201612 removed

Remove an old triaging keyword.

comment:8 Changed 2 years ago by nickm

Keywords: tor-pt tor-fw-helper windows unix compatibility added; pt removed

comment:9 Changed 8 months ago by ahf

Resolution: implemented
Status: acceptedclosed

These functions was removed when the process subsystem was introduced in 0.4.0. Closing this ticket.

Note: See TracTickets for help on using tickets.