Opened 10 years ago

Closed 9 years ago

#1169 closed defect (fixed)

Certain types of popups are blocked

Reported by: mikeperry Owned by:
Priority: High Milestone:
Component: Applications/Torbutton Version: 1.2.3
Severity: Keywords:
Cc: mikeperry, NetMerc, BWX Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description (last modified by mikeperry)

In torbutton 1.2.3, certain types of website popups seem to be appearing as blank pages as opposed to working
properly.

I am still looking for popup examples to reproduce this behaviour. It has been reported to me second hand via
http://forums.mozillazine.org/viewtopic.php?f=38&t=1639705 but they did not list specific sites. Please
provide sites/html test cases if you have any.

[Automatically added by flyspray2trac: Operating System: All]

Child Tickets

Attachments (4)

torbutton-1.2.4pre5.xpi (425.9 KB) - added by mikeperry 10 years ago.
torbutton-1.2.5pre1.xpi (421.8 KB) - added by mikeperry 9 years ago.
torbutton-1.2.5pre9.xpi (383.0 KB) - added by mikeperry 9 years ago.
torbutton-1.2.5pre11.xpi (408.2 KB) - added by mikeperry 9 years ago.

Download all attachments as: .zip

Change History (30)

comment:1 Changed 10 years ago by mikeperry

This is possibly due to a regression from the fix for the certificate dialog boxes in Firefox 3.5
(Bug 1093). That bugfix had a similar regression that was fixed prior to 1.2.3 for many types of popups.
Unfortunately, the types of popups blocked by this bug are seemingly different than the ones I tested
for that regression.

comment:2 Changed 10 years ago by mikeperry

Update:

I've tested 1.2.3 on Firefox 3.0.15 and 3.5.5 on Linux on the "Rate this page" popup in the top of
salesforce.com, and on the "search" popup in the upper right corner of bmo.com. Both work just
fine for me. In addition, I've tested all the popups on the following pages, some of which firefox
blocks, but all those that it does not block appear to work:

http://blazonry.com/javascript/windows.php
http://www.globalrph.com/davescripts/popup.htm
http://www.javascript-coder.com/window-popup/javascript-window-open.phtml

This was done with Tor enabled.

comment:3 Changed 10 years ago by NetMerc

I have been able to reliably recreate this issue.

I have Tor Button v1.2.3 installed with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.5) Gecko/20091102 Firefox/3.5.5 GTBDFff GTB7.0.; Google Toolbar 7.0.20091214Wb1.

With Tor off and TorButton set to 'disabled' and my Google tool bar is enabled certain types of popups are "blank". If I disable Google Tool bar, the open normally, when I reverse it and disable Google Toolbar and Disable TorButton, the open normally.

The most handy option I have is one forums that have a WYSIWYG editor that opens in a popup window. At work we use a web-based ticketing solution that is affected by this issue. Please contact for more information.

  • Michael

comment:4 Changed 10 years ago by NetMerc

Another example I have found - The ShareThis pop-up for FaceBook, or the 'Share on FaceBook' pop-ups.

comment:5 Changed 10 years ago by mikeperry

  1. Dixon: So to clarify, you are saying that this is definitely a conflict between google toolbar and Torbutton? If

Google Toolbar is disabled, the problem does not happen, but if it is enabled, popups are blocked if you're in either
Tor or non-Tor mode?

Just to confirm, is this the google toolbar you have: https://addons.mozilla.org/en-US/firefox/addon/6249

Can you try the 3 popup urls I placed in the second comment with google toolbar enabled and let me know what happens
with them with google toolbar + torbutton?

comment:6 Changed 10 years ago by mikosh

i had the same issue that i already reported on mozilla support:

If i open a new window, it's all ok, but if i click on a link that opens a new window, only if it's opening with javascript, that new window has address bar stuck in 'Search Bookmarks & History' and the page is blank. The only thing i can do is close that window...
It happens on different sites, that work with other browsers and worked before also on firefox... (for example at http://www.pageresource.com/jscript/jwinopen.htm the last button "new window" on bottom of page)

i found that disabling torbutton 1.2.3 solved this issue...

Firefox version - 3.5.5
Operating system - Intel Mac OS X 10.6
User Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; it; rv:1.9.1.5) Gecko/20091102 Firefox/3.5.5 GTB6

my extensions:
-downthemall 1.1.7
-firebug 1.4.5
-firephp 0.3.1
-flashgot 1.2.1.04
-google gears 0.5.33.0
-google toolbar for firefox 6.1.20090917mb1
-igetter extension 2.7.5
-opendownload 1.0.0
-torbutton 1.2.3
-ubiquity 0.5.4
-vacuum places improved 1

my plugins:

  • Gecko default plugin
  • Runs Java applets using the latest installed versions of Java. For more information: Java Embedding Plugin. Run version test: Java Information.
  • Picasa plugin.
  • iGetterBundle
  • QuickTime Plugin consente di visualizzare una grande varietà di contenuti multimediali nelle pagine Web. Per maggiori informazioni, visita il sito QuickTime.
  • Shockwave Flash 10.0 r32
  • LogMeIn remote control components
  • Google Talk Browser Plugin
  • 3.0.40818.0
  • Office Live Update v1.0
  • The Flip4Mac WMV Plugin allows you to view Windows Media content using QuickTime.
  • RealPlayer Plugin
  • DivX Web Player version 1.4.0.233
  • DivX Content Upload Plug-In: Uploads DivX video in your browser!
  • iPhoto6

comment:7 Changed 10 years ago by mikeperry

mikosh: That popup works for me. Can you please try re-enabling torbutton but disabling your google toolbar
and verify if that allows the popups to work again? M Dixon has reported that this is likely a conflict. I
just want to make sure you have the same conflict.

comment:8 Changed 10 years ago by NetMerc

Mike -

I am using the Google Toolbar from http://www.google.com/toolbar/ff/index.html

If TorButton and Google Toolbar are both enabled at the same time = Certain pop-ups are blank.

If just TorButton - Pop-ups work as expected.

If just Google Toolbar - Pop-ups work as expected.

I will try the pop-up and post my results.

  • Michael

comment:9 Changed 10 years ago by NetMerc

Mike -

Here are my results with TorButton installed/Enable and Google Toolbar installed/Enabled (Using FireFox 3.5.5):

http://blazonry.com/javascript/windows.php - All popups open and are blank. (not the normal result - verified by IE7)
Window 1 - Blank
Windows 2 - Blank
Windows 3a - Blank, Windows 3b - Contains text
Window 4 - Blank

http://www.globalrph.com/davescripts/popup.htm - All popups open and are blank. (not the normal result - verified by IE7)

http://www.javascript-coder.com/window-popup/javascript-window-open.phtml - All popups load as a new tab but they do contain text. I also verified how the would work in IE7.


Here are my results with TorButton installed/Disabled and Google Toolbar installed/Enabled (Using FireFox 3.5.5):

http://blazonry.com/javascript/windows.php - All popups open and work as expected
Window 1 - Works (contains text)
Windows 2 - Works (is blank)
Windows 3a - Works (contains text)
Window 4 - Works (contains text)

http://www.globalrph.com/davescripts/popup.htm - All 3 popups open and contain text.
http://www.javascript-coder.com/window-popup/javascript-window-open.phtml - All popups load as a new tab but they do contain text


Here are my results with TorButton installed/Enabled and Google Toolbar installed/Disabled (Using FireFox 3.5.5):

http://blazonry.com/javascript/windows.php - All popups open and work as expected
Window 1 - Works (contains text)
Windows 2 - Works (is blank)
Windows 3a - Works (contains text)
Window 4 - Works (contains text)

http://www.globalrph.com/davescripts/popup.htm - All 3 popups open and contain text.
http://www.javascript-coder.com/window-popup/javascript-window-open.phtml - All popups load as a new tab but they do contain text

It seems like the popup is blank IF the popup is supposed to also contain some sort of text. Hope this helps.

  • Michael

Changed 10 years ago by mikeperry

Attachment: torbutton-1.2.4pre5.xpi added

comment:10 Changed 10 years ago by mikeperry

Ok I installed the google toolbar for linux from the url you provided and experienced the issue. It did not
happen all the time for some reason, but it did happen a lot.

I have placed a fix XPI in the attachments tab above that works for me for the Linux version of the toolbar
(which may be different than windows). Please test it thoroughly and let me know if it fixes the issue or if
any other issues appear.

comment:11 Changed 10 years ago by mikosh

Hi Mike, thanks for your time!
i haven't installed your patch yet...
i tested combinations of google toolbar and torbutton and i had same exact result of M.Dixon

Here are my results with TorButton installed/Enable and Google Toolbar installed/Enabled (Using FireFox 3.5.5):
http://blazonry.com/javascript/windows.php - All popups open and are blank.

Here are my results with TorButton installed/Disabled and Google Toolbar installed/Enabled (Using FireFox 3.5.5):
http://blazonry.com/javascript/windows.php - All popups open and work as expected

Here are my results with TorButton installed/Enabled and Google Toolbar installed/Disabled (Using FireFox 3.5.5):
http://blazonry.com/javascript/windows.php - All popups open and work as expected

now i'm going to install your patch and will report about it.
thanks again
Michele

(just noticed that my name is Michele, in italian, and yours are Mike and Michael...)

comment:12 Changed 10 years ago by mikosh

i just installed your fix XPI and every popup tried before, now works right!!
with torbutton and google toolbar both enabled

thanks again...

PS: for you tests, my user agent is: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; it; rv:1.9.1.5) Gecko/20091102 Firefox/3.5.5 GTB6

comment:13 Changed 10 years ago by NetMerc

Most excellent! Everything works. Thank you Mike, and Michele!

comment:14 Changed 10 years ago by e-cat

Hi, I can confirm the problem with torbutton. An interesting behavior not mentioned in the original bug report is that when the popup link (like this one here http://www.javascript-coder.com/window-popup/javascript-window-open-example1.html) is clicked 3 times or more, one or more of the popups do open with their intended content.

comment:15 Changed 10 years ago by e-cat

And i can also confirm that the fix XPI works for me too (ffox 3.5.6, Windows XP, google toolbar 6.1.20091119W)

comment:16 Changed 9 years ago by serya

I investigated the issue and like to share my finding.

The Google Toolbar creates a few 'browser' XUL elements out of the 'tabbrowser'. The torbutton_weblistener.onStateChange method calls torbutton_check_progress which calls torbutton_update_tags.

This method gets wm.getBrowserForContentWindow(win.top) which doesn't work correctly for 'browsers' placed out of the tabbrowser (it returens the selected browser to the last used tabbrowser in this case). It sets the tb_tor_fetched flag on the wrong browser and makes its content blocked.

This change http://gitweb.torproject.org/torbutton/torbutton.git/commit/b6b21a4558e5882ef407a5c6412ef1b587cfd1d0 brakes the sequence described above but it still looks like a potential bug. Doesn't it?

comment:17 Changed 9 years ago by BWX

TOR-Button blocks ALL popup-window-referrers on my pc, even if the TOR-Button is disabled (but as the extension generally enabled).

I'm using:

  • Windows XP Pro
  • Firefox 3.6 Portable
  • Vidalia Portable
  • TOR-Button 1.2.4 and afterwards 1.2.4pre5
  • BetterPrivacy Extension

It happeneds if I enable in TOR-Button-Settings on the tab "Security Settings" the checkmark at "Dynamisch generierte Daten während der Benutzung von Tor separieren (wichtig)".
It is german and means something like "separate dynamically generated data during the use of TOR (important)".

If I uncheck this, all the popups work fine.

Another big problem is, that TOR-Button is ACTIVELY WORKING, even if I have it DISABLED (not the extension is disabled, but just the red X is over the onion). Of course do I have set all the settings in TOR-Button in a way, that TOR-Button is NOT doing anything while turned off.

Thx

comment:18 Changed 9 years ago by mikeperry

Does this same problem happen to you in a regular non-portable Firefox 3.6 install? I wonder if there is something
really broken in that portable version. Are there any error messages in the javascript error console log, or
torbutton log messages there?

What about if you go into torbutton's preferences and click "Restore Defaults"? is everything still broken? What if you remove Torbutton and reinstall it?

This is very strange behaviour. Sounds like some kind of state conflict issue.

comment:19 Changed 9 years ago by BWX

I don't know, because I don't have a fixed FF installed. But I'm using FF portable and TorButton since a long time w/o any problem.

Some friends, who I gave a few month ago the same FF portable with the included TB had exactly the same problem with the same solution to fix it.

Yes, with the factory defaults the problem is still present, probably because in this defaults the aforementioned checkmark is also set; btw, this checkmark is set since a long time and never made any problems.

If I reinstall the TB I still have the same problem in the same situation.

Good News! I made some intensiv nightly testings and could delimit the problem.
Another Extension (CoolPreview) evokes this problem when updating from version 2.7 to version 3.1.
With version 2.7 of the CoolPreview extension I can set the TB setting "separate dynamically generated data during the use of TOR (important)" w/o having any problems.
After the update to version 3.1 the problem with the empty popups arise.

Finally it has nothing to do with the version of FF or TB; I tried it in all crossover versions and it is all the same.
I guess, that the FF update to version 3.6 and the CoolPreview update to v3.1 was at about the same time, so I got misleaded with this info.

I did setup two folders of FF portable: one with CoolPreview in version 3.7 and w/o the popup problem, and another folder with FF portable and CoolPreview in version 3.1 and the problem present.
You can download the RAR file with the two portables here: http://www.blue-worx.net/FF-Portables.rar
With this you are enabled to reproduce this problem by yourself.

In the "NOT Working" folder, if you uncheck the aforementioned chekmark in TB you can see how the popups start working again. For this, I did put a link to a website in the bookmarks for testing purpose. Just klick on the link called "XXL Bilder" below the BMW pictures and a window should popup with a photogallery of this car. Otherwise it stays blank.

Hope I could help with this information. If you need any more testings, just tell me.

Thx

comment:20 Changed 9 years ago by mikeperry

Ok, for my own sanity, it seems the most reliable way to reproduce this are the first and second links I
mentioned above:

http://blazonry.com/javascript/windows.php
http://www.globalrph.com/davescripts/popup.htm

The third link seems to behave fine. Also, the behaviour is not 100% reproducible. Sometimes it takes a while
to happen..

Changed 9 years ago by mikeperry

Attachment: torbutton-1.2.5pre1.xpi added

comment:21 Changed 9 years ago by mikeperry

Ok, I think I have a fix for the conflict.

Please try the Torbutton 1.2.5pre1.xpi attachment in the attachments tab. It seems to fix the issue
for me.

Changed 9 years ago by mikeperry

Attachment: torbutton-1.2.5pre9.xpi added

comment:22 Changed 9 years ago by BWX

Hello,

with the 1.2.5pre9.xpi I get the following error when opening the settings (translated from german to english):

XML-Error: Not defined Entity
Address: chrome://torbutton/content/preferences.xul
Row Nr. 187, Col. 9:

<checkbox id="torbutton_updateTorbuttonViaTor"

With 1.2.5pre1.xpi everything was fine.

comment:23 Changed 9 years ago by mikeperry

Oh right, Heiko sorry about that. Its because we don't yet have a translation for that string. I need to do the magic
pootle dance to copy the new dtd entries over into the german translation. The english locale should not have that problem.

Changed 9 years ago by mikeperry

Attachment: torbutton-1.2.5pre11.xpi added

comment:24 Changed 9 years ago by mikeperry

Heiko and others: Please try the torbutton-1.2.5pre11.xpi in the attachments tab. It should fix localization
issues and all other problems.

comment:25 Changed 9 years ago by BWX

The 1.2.5pre11.xpi now works fine for me, thx Mike!

comment:26 Changed 9 years ago by mikeperry

Description: modified (diff)
Resolution: Nonefixed
Status: newclosed

Fixed in 1.2.5.

Note: See TracTickets for help on using tickets.