Opened 5 years ago

Closed 5 years ago

#11729 closed defect (fixed)

Test for curve25519-donna-c64 is broken when cross compiling

Reported by: conradev Owned by:
Priority: Medium Milestone: Tor: 0.2.5.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: tor-relay 024-backport
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

In #8587, the test for curve25519-donna-c64 was improved, but it doesn't work as expected when cross compiling. I'm cross compiling for armv7 and the test does not fail to compile, as current behavior expects it to. It fails to *link*, however, finding "_multi3" (128-bit multiply) to be an undefined symbol.

I attached a small patch that should fix this.

Child Tickets

Attachments (1)

use_curve25519_donna_c64_cross_compile.diff (446 bytes) - added by conradev 5 years ago.

Download all attachments as: .zip

Change History (5)

Changed 5 years ago by conradev

comment:1 Changed 5 years ago by nickm

Keywords: tor-relay 024-backport added
Milestone: Tor: 0.2.4.x-final

Looks fine to me. Merged to 0.2.5 as 388478561dd4457afedf530591f02cb05864b187, marked for possible backport to 0.2.4. Thanks!

comment:2 Changed 5 years ago by nickm

Status: newneeds_review

0.2.4 triage: do not backport to 0.2.4.22; only one person has noticed this, so it can't be coming up exceptionally often. Reconsider in 0.2.4.23.

comment:3 Changed 5 years ago by arma

I haven't heard anything about this, so I'm skipping for 0.2.4.23 too.

At this rate we should just close the ticket and tell such people to move to 0.2.5.x.

comment:4 Changed 5 years ago by arma

Milestone: Tor: 0.2.4.x-finalTor: 0.2.5.x-final
Resolution: fixed
Status: needs_reviewclosed

In fact, I'm going to do that. Thanks!

Note: See TracTickets for help on using tickets.