Opened 6 years ago

Closed 6 years ago

Last modified 4 years ago

#11750 closed defect (fixed)

Use siphash on chan_circid_entry_hash()

Reported by: nickm Owned by:
Priority: Medium Milestone: Tor: 0.2.5.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: tor-relay, security, tor-dos
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:


We missed this function when we were doing the huge siphash conversion. I hope it doesn't hurt performance too much here.

Child Tickets

Change History (6)

comment:1 Changed 6 years ago by nickm

Status: newneeds_review

Fix in branch bug11750 in my public repository.

comment:2 Changed 6 years ago by nickm

I improved the implementation a little by making sure the whole input would fit into a single csiphash round.

comment:3 Changed 6 years ago by Sebastian

The benchmark code doesn't do anything with the total variable, right?

comment:4 Changed 6 years ago by nickm

right. It was there out of a stupid what-if-the-compiler-optimizes-this idea.

comment:5 Changed 6 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

Okay, I'm calling this one mergeable too. And, merged.

comment:6 Changed 4 years ago by mikeperry

Keywords: tor-dos added; dos removed

Canonicalize dos tag to tor-dos

Note: See TracTickets for help on using tickets.