This is to do with how Torbutton checks if Tor is available. In your current setup, Torbutton is trying to connect to Tor's control port (to check your proxy settings) using the default port and password from Tor-Launcher; this fails because your system-wide tor process is using a different control port/password/cookie. You have a couple of options to work around this on windows:
Completely disable Tor-Launcher in about:addons so that no default port/password is available. This will completely disable the New Identity feature, since requesting a new circuit requires control port access. Torbutton will now check Tor using check.torproject.org in the background and succeed.
or
Pass your system-wide Tor's control port/password/cookie to the browser on start-up. This is done by setting the environment variables TOR_CONTROL_PORT, TOR_CONTROL_PASSWD or TOR_CONTROL_COOKIE_AUTH_FILE (and maybe TOR_CONTROL_HOST). Torbutton will now be able to perform the control port check. Additionally new identity will now work. Note you must supply the control password in double quotes (e.g. "password" rather than password)
This was the first time I set an environment variable in Windows. It was enough to set the file path for TOR_CONTROL_COOKIE_AUTH_FILE (I'm using similar torrc settings from Tor Browser). Now it shows Congratulations.
I have a patch, based on brade's bug11641 branch (because they changed the paths around in the Tor Browser repo), which fixes this by adding documentation on all the TorButton and TorLauncher Firefox settings which should be changed, as well as a bash function to help users correctly set their TOR_CONTROL_PASSWD with the correct quoting syntax. The patch is a single commit in my bug10178_bug11751 branch and my repo is at https://github.com/isislovecruft/tor-browser-bundle . It also fixes #10178 (closed).
Additionally, there is an extra bug10178_bug11751-log-to-file-and-disown branch based on that last branch (because I'm not sure if mikeperry would want this patch, but it's what I personally run in my start-tor-browser script). It has one more commit which makes makes Tor Browser log to a file, and then it disowns the Firefox process from the shell and exits the script. This prevents the output from ending up in unpredictable places (it often includes full URIs logged from HTTPSEverywhere), and it also prevents having a shell remain open during the browser session which is just spewing debugging crap all over the place.
Both commits have rather verbose commit messages, explaining the bash syntax and reasoning behind it.
Additionally, there is an extra bug10178_bug11751-log-to-file-and-disown branch based on that last branch (because I'm not sure if mikeperry would want this patch, but it's what I personally run in my start-tor-browser script). It has one more commit which makes makes Tor Browser log to a file, and then it disowns the Firefox process from the shell and exits the script. This prevents the output from ending up in unpredictable places (it often includes full URIs logged from HTTPSEverywhere), and it also prevents having a shell remain open during the browser session which is just spewing debugging crap all over the place.
I made sure that start-tor-browser wouldn't spew its stdout or stderr into random files (unless someone passes the --debug option on the command line). See the first 150 lines.
Both commits have rather verbose commit messages, explaining the bash syntax and reasoning behind it.
It's a /bin/sh script, not a bash script. Don't put bashisms into it.
For the record, I had to rebase my commits. They are now in the branches bug10178_bug11751_rebase1 and bug10178_bug11751-log-to-file-and-disown_rebase1. Though perhaps my patches only fix #10178 (closed), since this issue is now specifically for Windows.
Doesn't need review anymore? What is the status here?
The documentation for Windows is missing as it is possible to use the expert bundle with Tor Browser (see comment:2). Changing the title of this bug again.
Trac: Type: defect to task Summary: Windows users can't use TBB with expert bundle Tor to Add documentation for using TBB with Windows Tor expert bundle Keywords: tbb-torbutton deleted, N/Aadded