Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#11879 closed defect (fixed)

'Open Settings' button doesn't stop Tor from bootstrapping

Reported by: asn Owned by: brade
Priority: Medium Milestone:
Component: Applications/Tor Launcher Version:
Severity: Keywords: tbb-4.5-alpha, TorBrowserTeam201504R
Cc: mcs Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

This is not really a bug, but it's a bit annoying and maybe other people have noticed it too.

If you have bootstrapped with TBB before, TBB gives you the chance to change your settings by clicking on the 'Open Settings' button during bootstrap. The weird thing is that if you click 'Open Settings', Tor will keep on trying to bootstrap with the old configuration.

Maybe it makes sense to issue a NetworkDisabled call, when the 'Open Settings' button is clicked? Or maybe not?

(This made me a bit nervous the other day, because I clicked "Connect directly to Tor network" on a new TBB by mistake, and then I wanted to cancel it immediately. So I closed TBB, and restarted and when I pressed 'Open Settings' to add some bridges, Tor vanilla bootstrapped in the background. I don't particularly care about this, but maybe other people do).

Child Tickets

Change History (12)

comment:1 Changed 5 years ago by mcs

Cc: mcs added

comment:2 Changed 5 years ago by mcs

brade and I agree that clicking "Open Settings" should stop the bootstrap process.

We have a fix for this, but we experienced a problem: after interrupting the bootstrap process by setting DisableNetwork=1, tor does not always resume the process when DisableNetwork is cleared. It is possible this is fixed in tor 0.2.5.x (we tested using TBB 3.6.1, which includes tor 0.2.4.21). For now we are leaving the Tor Launcher change on a branch:

https://gitweb.torproject.org/user/brade/tor-launcher.git/commit/bc03f1c43d817d6e815f2a965329c9644618f7ea

We will test with a newer tor soon and file a bug against tor if the problem still occurs.

comment:3 Changed 5 years ago by mcs

Keywords: TorBrowserTeam201407 added

comment:4 Changed 5 years ago by mcs

Keywords: TorBrowserTeam201408 added; TorBrowserTeam201407 removed

comment:5 Changed 5 years ago by mikeperry

Keywords: TorBrowserTeam201410 added; TorBrowserTeam201408 removed

Ok, we can test this again after FF31esr is ready.

comment:6 Changed 5 years ago by mikeperry

Keywords: TorBrowserTeam201411 added; TorBrowserTeam201410 removed

comment:7 Changed 5 years ago by asn

FWIW, this still happens with 4.5-alpha-1.

comment:8 Changed 5 years ago by mikeperry

Keywords: TorBrowserTeam201411 removed

comment:9 Changed 5 years ago by mcs

Keywords: tbb-4.5-alpha TorBrowserTeam201504R added
Status: newneeds_review

Kathy and I tested this with TB 4.5 / Tor 0.2.6.x and did not see the problem that we observed with Tor 0.2.4.x (where bootstrapping failed to restart after DisableNetwork was set back to 0). We did notice two smaller problems:

a) Sometimes there is a delay (approximately 1 minute) before network activity continues.
b) Depending on when you click "Open Settings" to stop the bootstrap, you may see a spurious error like:

Tor failed to establish a Tor network connection.
Loading network status failed (no route to host - xxx.xxx.xxx.xxx).

With those caveats, it does seem like a nice improvement to interrupt the bootstrap process when the user clicks Open Settings or Cancel. Here is a revised patch:
https://gitweb.torproject.org/user/brade/tor-launcher.git/commit/?h=bug11879-02&id=81fd61c79e77e8dcbcfa42559a727ac384583f03

Please review.

comment:10 Changed 5 years ago by mikeperry

Ok, I merged this, as I agree that it is important to allow users to stop the bootstrapping process while they enter new settings.

If you have a repro case for the Tor errors and delay, please file Tor bugs for them? I guess also file them even if you don't, but I'm not filing them right now myself in the hope that you have repro cases :). You may want to cite #9229 and #11069 for the 1 minute hang, as it may be related to those issues.

comment:11 Changed 5 years ago by mikeperry

Resolution: fixed
Status: needs_reviewclosed

comment:12 in reply to:  10 Changed 5 years ago by mcs

Replying to mikeperry:

If you have a repro case for the Tor errors and delay, please file Tor bugs for them? I guess also file them even if you don't, but I'm not filing them right now myself in the hope that you have repro cases :). You may want to cite #9229 and #11069 for the 1 minute hang, as it may be related to those issues.

New tickets filed: #15713, #15715

Note: See TracTickets for help on using tickets.