Opened 10 years ago

Last modified 7 years ago

#1196 closed enhancement (Fixed)

upgrade log level of "Authenticated control connection" message to notice

Reported by: keb Owned by:
Priority: Very Low Milestone:
Component: Core Tor/Tor Version: 0.2.2.6-alpha
Severity: Keywords:
Cc: keb, Sebastian Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

It is important for normal operation and security
to know when something connects to the control port.
Don't really want to see all the other info logging
under normal circumstances though.

Suggest upgrading the message from log_info to log_notice.

[Automatically added by flyspray2trac: Operating System: All]

Child Tickets

Change History (5)

comment:1 Changed 10 years ago by Sebastian

I think this is a good idea.

Looks like we have two choices here, we can either promote the info
level log entry when we get a new authenticated controller connection,
(line 1131 in control.c) or add a new log message whenever we receive
any kind of control connection. I think the second idea is better, see
branch bug1196 in my repo ( http://gitweb.torproject.org/tor/sebastian.git/commitdiff/bug1196
) for a simple implementation.

comment:2 Changed 10 years ago by keb

agreed on 2nd idea. even more important to know about unauthenticated control connections.

comment:3 Changed 10 years ago by Sebastian

Will be merged at some time.

comment:4 Changed 10 years ago by Sebastian

flyspray2trac: bug closed.

comment:5 Changed 7 years ago by nickm

Component: Tor ClientTor
Note: See TracTickets for help on using tickets.