TestingServerDownloadSchedule et al imply they're for TestingTorNetwork but actually they're sometimes not
V(TestingServerDownloadSchedule, CSV_INTERVAL, "0, 0, 0, 60, 60, 120, "
"300, 900, 2147483647"),
is the default value of the config option, and that's used in the real Tor network:
static const smartlist_t *
find_dl_schedule_and_len(download_status_t *dls, int server)
{
switch (dls->schedule) {
case DL_SCHED_GENERIC:
if (server)
return get_options()->TestingServerDownloadSchedule;
else
return get_options()->TestingClientDownloadSchedule;
[...]
But if you set TestingTorNetwork, then its value gets replaced by
V(TestingServerDownloadSchedule, CSV_INTERVAL, "0, 0, 0, 5, 10, 15, "
"20, 30, 60"),
and the code in directory.c stays the same.
Am I the only one who thinks that calling it a TestingFooBarSchedule when it's not for Testing is weird?