Opened 5 years ago

Closed 5 years ago

#12091 closed defect (fixed)

BridgeDB still isn't checking DKIM verification results properly

Reported by: isis Owned by: isis
Priority: Very High Milestone:
Component: Circumvention/BridgeDB Version:
Severity: Keywords: bridgedb-email, security, easy
Cc: isis, sysrqb Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

From this commit message for this unittest:

Also, "dunno" certainly isn't a valid DKIM signature.


See the ticket description for #12086 for how

15:30:31 DEBUG  L495:server.lineReceived()  > X-DKIM-Authentication-Results: dunno

ended up in the headers on an incoming email in the first place.

Child Tickets

Change History (1)

comment:1 Changed 5 years ago by isis

Resolution: fixed
Status: newclosed

There are three new unittests added in my fix/12091-dkim-dunno branch, which will specifically tell us if this case is being handled correctly in the bridgedb.email.autoresponder.SMTPAutoreponder class and the bridgedb.email.dkim.checkDKIM() function.

The actual fixes for this bug are in my fix/9874-automate-email-tests branch, which fix/12091-dkim-dunno is based upon.

Note: See TracTickets for help on using tickets.