Opened 5 years ago

Closed 5 years ago

#12153 closed defect (fixed)

Chat window size is too small

Reported by: lunar Owned by: Sherief
Priority: Medium Milestone:
Component: User Experience/Tor Support Version:
Severity: Keywords: pups
Cc: sherief Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

The size of the chat window is too small for a long conversation and looks tiny on a computer with a large screen. It should be resized to take almost all space.

Child Tickets

Attachments (2)

pups.png (45.2 KB) - added by Sherief 5 years ago.
pups2.png (20.1 KB) - added by Sherief 5 years ago.

Download all attachments as: .zip

Change History (9)

comment:1 Changed 5 years ago by Sherief

Owner: changed from lunar to Sherief
Status: newaccepted

comment:2 Changed 5 years ago by Sherief

Status: acceptedneeds_review

https://github.com/SheriefAlaa/pups/commits/bug12153 this topic branch contains a fix but it's based on the webchat_patches branch.

Changed 5 years ago by Sherief

Attachment: pups.png added

Changed 5 years ago by Sherief

Attachment: pups2.png added

comment:3 Changed 5 years ago by lunar

Status: needs_reviewneeds_revision

webchat_patches had changed in the meantime. Could you please rebase on master now that the former has been merged?

comment:4 in reply to:  3 Changed 5 years ago by Sherief

Replying to lunar:

webchat_patches had changed in the meantime. Could you please rebase on master now that the former has been merged?

I just pulled the new master branch you merged at git.tpo then merged it with the topic branch (it did a recursive merge). Is this what you meant?

Please see: https://github.com/SheriefAlaa/pups/commits/bug12153

Thanks.

comment:5 Changed 5 years ago by lunar

It's not ok as it still contains the commit you rewrote on the other branch. That's why I said rebase instead of merge.

See by yourself:

$ git log --oneline origin/master..sherief/bug12153
be2c2aa Merge branch 'master' into bug12153
f35c9f6 Merge branch 'webchat_patches' into bug12153
ca6aad3 [#12153] Expands Webchat's chat window
dbd830e [#12626] Fixes multi-line support in webchat

comment:6 in reply to:  5 Changed 5 years ago by Sherief

Replying to lunar:

It's not ok as it still contains the commit you rewrote on the other branch. That's why I said rebase instead of merge.

See by yourself:

$ git log --oneline origin/master..sherief/bug12153
be2c2aa Merge branch 'master' into bug12153
f35c9f6 Merge branch 'webchat_patches' into bug12153
ca6aad3 [#12153] Expands Webchat's chat window
dbd830e [#12626] Fixes multi-line support in webchat

Better now?
https://github.com/SheriefAlaa/pups/commits/bug12153

comment:7 Changed 5 years ago by lunar

Resolution: fixed
Status: needs_revisionclosed

Merged. :)

Note: See TracTickets for help on using tickets.