Chat window size is too small

The size of the chat window is too small for a long conversation and looks tiny on a computer with a large screen. It should be resized to take almost all space.

added component::user experience/tor support owner::Sherief priority::medium pups resolution::fixed status::closed type::defect labels

Trac:
Owner: lunar to Sherief
Status: new to accepted

https://github.com/SheriefAlaa/pups/commits/bug12153 this topic branch contains a fix but it's based on the webchat_patches branch.

Trac:
Status: accepted to needs_review

Trac:

Trac:

webchat_patches had changed in the meantime. Could you please rebase on master now that the former has been merged?

Trac:
Status: needs_review to needs_revision

Replying to lunar:

webchat_patches had changed in the meantime. Could you please rebase on master now that the former has been merged?

I just pulled the new master branch you merged at git.tpo then merged it with the topic branch (it did a recursive merge). Is this what you meant?

Please see: https://github.com/SheriefAlaa/pups/commits/bug12153

Thanks.

It's not ok as it still contains the commit you rewrote on the other branch. That's why I said rebase instead of merge.

See by yourself:

$ git log --oneline origin/master..sherief/bug12153
be2c2aa Merge branch 'master' into bug12153
f35c9f6 Merge branch 'webchat_patches' into bug12153
ca6aad3 [#12153] Expands Webchat's chat window
dbd830e [#12626] Fixes multi-line support in webchat

Replying to lunar:

It's not ok as it still contains the commit you rewrote on the other branch. That's why I said rebase instead of merge.

See by yourself:

{{{ $ git log --oneline origin/master..sherief/bug12153 be2c2aa Merge branch 'master' into bug12153 f35c9f6 Merge branch 'webchat_patches' into bug12153 ca6aad3 [#12153 (closed)] Expands Webchat's chat window dbd830e [#12626 (closed)] Fixes multi-line support in webchat }}}

Better now? https://github.com/SheriefAlaa/pups/commits/bug12153

Merged. :)

Trac:
Status: needs_revision to closed
Resolution: N/A to fixed

closed