Opened 6 years ago

Closed 3 years ago

Last modified 3 years ago

#12155 closed defect (fixed)

Support fully incremental TBB developer builds

Reported by: mikeperry Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: gitian, tbb-gitian
Cc: mikeperry, gk Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

We should figure out some way to make it less painful for newcomers to create dev builds for testing patches against TBB, especially for Firefox.

Right now, developing patches for TBB requires waiting for an end-to-end Gitian build. We added support for rebuilding only select components of the bundle, but we could take this a step further by allowing incremental builds without having to rebuild everything in a given component.

There are several ways to accomplish this. The easiest will be if we allow partial rebuilds without preserving the reproducibility property. This will be the parent ticket for all manner of ways of doing this, reproducible or not.

Child Tickets

TicketStatusOwnerSummaryComponent
#12156closedmikeperryProvide a helper script/instructions to package up a non-gitian compiled Firefox for GitianApplications/Tor bundles/installation

Change History (4)

comment:1 Changed 6 years ago by gk

As said on #tor-dev I wonder why we really need this and bother newcomers even with a "Gitan-light"-workflow. Rephrasing my reasoning:

What I did to debug #9531 was
1) Clone tor-browser repo.
2) Apply/develop your patch.
3) Build Tor Browser.
4) Take an already existing bundle and extract the result of 2) into /Browser.
5) Happy patch testing/debugging.
6) If needed go back to 2).

That worked pretty well for me and has the huge advantage for newcomers that there is no Gitian at all to be concerned with. Rather, the are able to concentrate on the Tor Browser feature/bug alone. As Gitian is only necessary for reproducibility and more than 99% of the patches developed won't mess with it I see no problem in taking this shortcut. We, who have the setup handy can then easily test the reproducibility bits if that is deemed necessary.

The only thing that is needed then is updating our HACKING document.

comment:2 Changed 6 years ago by erinn

Component: Tor bundles/installationTor Browser
Keywords: tbb-gitian added
Owner: changed from erinn to tbb-team

comment:3 Changed 3 years ago by gk

Resolution: fixed
Severity: Blocker
Status: newclosed

I think this is solved for rbm where one can (re)build just single components for particular architectures, see comment:26:ticket:10026 for an example.

comment:4 Changed 3 years ago by gk

Severity: BlockerNormal
Note: See TracTickets for help on using tickets.